Skip to content

refactor(agent-tools): extract tool manifest contracts#770

Merged
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/refactor-p14-tool-manifest-closure
May 18, 2026
Merged

refactor(agent-tools): extract tool manifest contracts#770
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/refactor-p14-tool-manifest-closure

Conversation

@limityan
Copy link
Copy Markdown
Collaborator

Summary

  • Move pure tool manifest/exposure contracts into bitfun-agent-tools: ToolExposure, GetToolSpec name, manifest policy resolution, collapsed prompt stub construction, and prompt-visible ordering.
  • Keep runtime behavior in core: product registry snapshot, context-aware schema/description, GetToolSpecTool execution, ToolUseContext, unlock state, snapshot decoration, and concrete tool implementations remain core-owned.
  • Update boundary checks and decomposition docs so this contract closure is not mistaken for runtime owner migration.
  • Add focused owner-crate contract tests, including manifest definition serde round-trip and existing GetToolSpec insertion/ordering behavior.

Guardrails

This PR is intended to be behavior-preserving. It does not change product tool availability, expanded/collapsed exposure semantics, prompt-visible collapsed stubs, unlock behavior, desktop/MCP/ACP catalog behavior, or concrete tool execution paths.

Validation

  • cargo test -p bitfun-agent-tools -- --nocapture
  • cargo test -p bitfun-core manifest_resolver -- --nocapture
  • cargo test -p bitfun-core get_tool_spec -- --nocapture
  • cargo check -p bitfun-core --features product-full
  • node scripts/check-core-boundaries.mjs
  • git diff --check

@limityan limityan merged commit 894291e into GCWing:main May 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant