Fix remote flashgrep overwrite on SFTP hosts#780
Open
wgqqqqq wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR narrows the remote flashgrep bundle replacement path in
RemoteWorkspaceSearchService::ensure_remote_flashgrep_binary.When the bundled binary hash differs from the remote binary hash, BitFun no longer writes directly to the final remote binary path over SFTP. Instead it now:
mv -f temp targetchmod 755step on the final pathWhy
On the affected remote host, SFTP accepts uploads to new files but rejects opening an existing file for overwrite/truncate with a generic
Failureerror.We reproduced all three cases against the saved Alibaba Cloud remote connection:
.bitfun/binsucceedsflashgrep-x86_64-unknown-linux-muslvia SFTP failsThat failure happens before the remote stdio daemon starts, so repository status/search requests fail during flashgrep bundle refresh.
Scope
This change only affects the remote flashgrep bundle installation path when BitFun decides the remote binary must be replaced.
It does not change:
Validation
cargo check -p bitfun-coreupload temp file + mv -f targetsucceeds on the same host