refactor(function-agents): route startchat through facade#782
Merged
limityan merged 1 commit intoMay 19, 2026
Merged
Conversation
Wire Startchat work-state analysis through the product-domain runtime facade using core-owned Git and AI adapters, while preserving legacy git-state, diff fallback, time-info, and analyzed_at boundaries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FunctionAgentRuntimeFacadeusing core-owned Git and AI adapters.analyze_git=falsetime-info, and post-analysisanalyzed_atassignment.Functional Boundary
This PR is intended to be behavior-preserving. It does not move Git service execution, AI client selection, prompt templates, JSON extraction, or error mapping out of core. It only changes the Startchat work-state product path to use the already-defined product-domain facade with the same core-owned adapters underneath.
Validation
git rebase gcwing/maingit diff --check gcwing/main...HEADnode scripts/check-core-boundaries.mjscargo test -p bitfun-product-domains --no-default-featurescargo tree -p bitfun-product-domains --no-default-features --depth 1 --edges featurescargo test -p bitfun-product-domains --features product-fullcargo test -p bitfun-core function_agents:: -- --nocapturecargo check -p bitfun-core --features product-fullrustfmt --edition 2021 --check src\crates\core\src\function_agents\startchat-func-agent\work_state_analyzer.rs src\crates\core\src\function_agents\port_adapters.rs src\crates\product-domains\src\function_agents\ports.rs