Add support for forwarding touch keyboard input to the application#1336
Add support for forwarding touch keyboard input to the application#1336valiantgamingpoint-prog wants to merge 2 commits into
Conversation
|
Thank you for this PR. It does work well, I tested it on Firefox Android with the FUTO keyboard. I appreciate the attention to details and blocking arrows scrolling. This said, I am hesitant to pull it into the main branch. The reason we didn't implement the keyboard this way is that it lacks support for tab. We didn't decide on a solution for this. We considered:
If this was an application for people who know how to code, then not having any of this would be ok. But since this is an application aimed at people who might have never coded before, leaving them without any obvious way to enter a tab character is problematic. I'm not convinced by any of the solutions above, to be honest. I'm open to any suggestion you may have (or anyone else reading). Note: once we reach an agreement, I'll review your code, but I'd rather not tell you to change anything before we know if we want the code in. I looked at it quickly, it all seems good for me, but if we find a way to make it work, I'll ask you to port the JS code into |
|
I'll be keeping this around for reference but we wouldn't be able to merge this as it is. The comments look off though that's just a matter of cleaning things up. Most importantly there's what Jad explained and more generally the user experience side of things that's needed to address issue #847. See the last comment in #847. If anyone reads this and would like to participate to this, that would be most welcome. |
Please check if the PR fulfills these requirements:
Related issue: #847