fix: CSV output in coupled simulation#4009
Open
bd713 wants to merge 7 commits into
Open
Conversation
bd713
requested review from
OmarDuran,
castelletto1,
frankfeifan,
jhuang2601 and
rrsettgast
as code owners
bd713
added
ci: run CUDA builds
kdrienCG
approved these changes
Jun 16, 2026
| GEOS_LOG_LEVEL_RANK_0( logInfo::TimeStep, GEOS_FMT( "New dt = {}", stepDt ) ); | ||
|
|
||
| // notify the solver statistics counter that this is a time step cut | ||
| getIterationStats().updateTimeStepCut(); |
Contributor
There was a problem hiding this comment.
Suggested change
| getIterationStats().writeIterationStatsToTable(); |
Is it intentional not to save the iteration stats for the CoupledSolver?
MelReyCG
approved these changes
Jun 18, 2026
| m_convergenceData.addRow( residualsNormCells ); | ||
|
|
||
| if( !m_CSVOutputOpened ) | ||
| if( MpiWrapper::commRank() == 0 ) |
Contributor
There was a problem hiding this comment.
Should it apply to the whole writeConvergenceStatsToTable() method?
Comment on lines
+149
to
+152
| real64 const setupTime = m_setupTime; | ||
| real64 const solveTime = m_solveTime; | ||
| resetSolverLinearTime(); | ||
|
|
Contributor
There was a problem hiding this comment.
Should it go before the first if? Maybe a scoped if can help.
Comment on lines
171
to
+172
| m_logStream << m_iterationCSVFormatter->headerToString( ); | ||
| m_CSVOutputOpened = true; | ||
| m_CSVOutputOpened = true; |
Contributor
There was a problem hiding this comment.
A bit of renaming could clarify: m_logStream -> m_csvStream
| // so writeIterationStatsToTable() early-returns: no rows expected. | ||
| } | ||
|
|
||
| TEST( CoupledSolverStatisticsCSVTest, checkCSVOutput ) |
Contributor
There was a problem hiding this comment.
IIUC, as this is the first unit-test that tests **Poromechanics solvers, should this test file be renamed testPoromechanics.cpp? (something like that)
To be more general, regrouping high-level integration-tests, can give an opportunity to optimize the loading time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.