Skip to content

DynCore: migrate scalar export fields to MAPL3 vector field bundles#389

Merged
pchakraborty merged 2 commits into
release/MAPL-v3from
feature/pchakrab/vector-fields
May 22, 2026
Merged

DynCore: migrate scalar export fields to MAPL3 vector field bundles#389
pchakraborty merged 2 commits into
release/MAPL-v3from
feature/pchakrab/vector-fields

Conversation

@pchakraborty
Copy link
Copy Markdown
Collaborator

Summary

Migrate DynCore export fields to MAPL3 vector field bundle conventions.

What changed

  • Remove vector_component_names from UV spec declarations
  • Add export specs for D_UV_DTANA, UV_KE, UV_PHI, UV_QV as MAPL3 vector bundles
  • Replace MAPL_StateGetPointer calls for scalar U/V exports with ESMF_StateGet + MAPL_FieldBundleGetPointer on the corresponding vector bundle
  • Split MAPL use statement into per-group lines
  • Remove stale commented-out CI option in .circleci/config.yml

Validation

  • Regression configs (adv-dyn, dyn-sa) updated in a companion commit to exercise the new vector bundle outputs

…aliases

- enable History child component in adv-dyn and dyn-sa cap.yaml configs
- add history.yaml for dyn-sa with vector field collections
- expand adv-dyn history.yaml to include UV, D_UV_DTANA, UV_KE, UV_PHI, UV_QV vector collections
- add alias() helper in cmpchk.py scripts to map U/V checkpoint vars to their indexed names (UV_1, UV_2) following the MAPL3 vector field naming convention
- remove vector_component_names from UV spec declarations
- add export specs for D_UV_DTANA, UV_KE, UV_PHI, UV_QV as MAPL3 vector bundles
- replace MAPL_StateGetPointer calls for scalar U/V exports with
  ESMF_StateGet + MAPL_FieldBundleGetPointer on the corresponding vector bundle
- split MAPL use statement into per-group lines
- remove stale commented-out CI option in .circleci/config.yml
@pchakraborty pchakraborty requested a review from a team as a code owner May 22, 2026 03:20
@pchakraborty pchakraborty self-assigned this May 22, 2026
@pchakraborty pchakraborty added 0 diff The changes in this pull request have verified to be zero-diff with the target branch. MAPL3 MAPL 3 Related Skip Changelog Contingent - DNA These changes are contingent on other PRs and removed Contingent - DNA These changes are contingent on other PRs labels May 22, 2026
Comment thread DynCore_StateSpecs.rc
Comment thread DynCore_GridCompMod.F90
MAPL_FieldBundleAdd, MAPL_FieldBundleSameData, MAPL_FieldBundleGetPointer, &
MAPL_RESTART_SKIP, MAPL_RESTART_REQUIRED, MAPL_ArrayGather
use MAPL, only: MAPL_Verify, MAPL_Assert, MAPL_Return
use MAPL, only: WRITE_PARALLEL, MAPL_Am_I_Root, MAPL_MaxMin, MAPL_AreaMean
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to all: I want to start lower casing the mapl prefix. But not in this PR as it only touched some of the USE statements in this repo.

@pchakraborty pchakraborty merged commit cf697c9 into release/MAPL-v3 May 22, 2026
20 of 22 checks passed
@pchakraborty pchakraborty deleted the feature/pchakrab/vector-fields branch May 22, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch. MAPL3 MAPL 3 Related Skip Changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants