Lake information into the GEOS BCS workflow#1214
Conversation
gmao-rreichle
left a comment
There was a problem hiding this comment.
@biljanaorescanin : I tried to clean up a bit. See also comments/questions below.
| integer, intent(in) :: nc_rst, nr_rst | ||
| integer, intent(in) :: tile_id(1:nc_rst, 1:nr_rst) | ||
|
|
||
| real(REAL64), intent(out) :: tile_lake_frac( 1:n_tile) |
There was a problem hiding this comment.
Do we really need REAL64 here? By construction, there are only 10 distinct real numbers in the 30 arcsec files: [0, 0.11111, 0.22222, ..., 0.88888, 1]. Even for a tile that spans a 1-deg by 1-deg area, there are still only ~10,000 raster (30 arcsec) grid cells. Single-precision should be able to accommodate the digits required to handle the useful information.
… not defined in "use netcdf" (rmTinyCatchParaMod.F90)
|
@gmao-rreichle In re last commit, what constants aren't defined in If some are missing, I can talk to the devs. |
|
@mathomp4 : For the record, I'm attaching the build log (0-2.txt) that I got when I replaced "include 'netcdf.inc'" with "use netcdf". Looks like nothing with "NF_" is available from "use netcdf". |
|
The last commit addresses all @gmao-rreichle comments. I reran the workflow after the updates. As expected, changing |
…0753af) (mkEASETilesParam.F90, rmTinyCatchParaMod.F90)
|
With last commit I've implemented the LakeTopoCat/ReachTopoCat option as one encoded output variable, The implementation reads |
This PR introduces HydroLAKES-TopoCat v1.1 (2023) lake and reach information into the GEOS BCS workflow.
This update does not alter tile geometry or Pfafstetter indexing. It augments tile metadata with a single encoded LakeTopoCat/ReachTopoCat touch type field.
It implements:
preproc/lake/v1with Python scripts and README..nc4files through updates tormTinyCatchParaModand related makebcs calls.@gmao-rreichle