Issue # 1411: Localize OpenMP thread use and count to the GCs theaded with mini-GS approach#1412
Open
aoloso wants to merge 2 commits into
Open
Issue # 1411: Localize OpenMP thread use and count to the GCs theaded with mini-GS approach#1412aoloso wants to merge 2 commits into
aoloso wants to merge 2 commits into
Conversation
…t the Grid Comp level when the mini gridcomp threading approach is used
aoloso
added
the
0 diff
Closed
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For GWD and GOCART2G threaded with the mini-gridcomp approach, the ability to selectively turn OpenMP off for those components where OpenMP is required for other components is not working as inteneded. The runtime option <use_threads: .FALSE.> to achieve that is being ignored. A branch called bugfix/aoloso/gridComp_level_numthrds has been created fro MAPL, GEOSgcm_GridComp, and GOCART to resolve this bug.
The affected files are <MAPL.F90, MAPL_Generic.F90, MaplGenericComponent.F90, OpenMP_Support.F90, GOCART2G_GridCompMod.F90, CA2G_GridCompMod.F90, DU2G_GridCompMod.F90, NI2G_GridCompMod.F90, SU2G_GridCompMod.F90 GEOS_GwdGridComp.F90>.