v12: Set default optics to RRTMGP#389
Open
mathomp4 wants to merge 3 commits into
Open
Conversation
mathomp4
added
the
0 diff
Member
Author
|
When this PR merges and GOCART defaults to RRTMGP optics, the corresponding GEOSgcm_App changes are in GEOS-ESM/GEOSgcm_App#878. That PR removes the now-redundant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In GEOSgcm v12, we have moved from RRTMG to RRTMGP by default. However, GOCART has continued with RRTMG optics by default.
So, this PR updates it to be RRTMGP by default. This is zero-diff because, at the moment, we do sed shenanigans in
gcm_run.jto change these lines at run time to RRTMGP.NOTE: This will require changes in GEOSgcm_App for running with RRTMG. See GEOS-ESM/GEOSgcm_App#878
cc: @sdrabenh