Skip to content

Fix/update apply app data method#642

Open
markgalvan-intel wants to merge 5 commits into
mainfrom
fix/update-apply-app-data-method
Open

Fix/update apply app data method#642
markgalvan-intel wants to merge 5 commits into
mainfrom
fix/update-apply-app-data-method

Conversation

@markgalvan-intel
Copy link
Copy Markdown
Collaborator

@markgalvan-intel markgalvan-intel commented Jun 5, 2026

Updating app provider attachment methodology. Instead of finding and attaching to the closest Present Start, will now attach to the Present where the app provided present start resides in the Present Start and Present End interval. Note this only used in the absence of the app frame it.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates how app/provider timing data is attached to PresentEvents, changing the matching logic from “closest earlier PresentStart” to matching based on whether the app-provided present start timestamp falls within the Present_Start → Present_Stop interval (with PC-latency keeping the prior heuristic behavior).

Changes:

  • Extend ExtractAppTimingData() to accept a present stop timestamp and a mode flag to select matching strategy.
  • Update call sites to pass Present_Stop time when attaching app timing data, and compute a stop bound for PC-latency attachment.
  • Implement interval-based selection for non-PC-latency timing data (time-in-window match).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
PresentData/PresentMonTraceConsumer.hpp Updates ExtractAppTimingData() signature to include presentStopTime and a mode flag.
PresentData/PresentMonTraceConsumer.cpp Passes present stop time into app-timing attachment and implements window-based timing-data selection logic.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread PresentData/PresentMonTraceConsumer.cpp Outdated
Comment thread PresentData/PresentMonTraceConsumer.cpp Outdated
markgalvan-intel and others added 3 commits June 5, 2026 08:36
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@planetchili planetchili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great stuff!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants