Fix/update apply app data method#642
Open
markgalvan-intel wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates how app/provider timing data is attached to PresentEvents, changing the matching logic from “closest earlier PresentStart” to matching based on whether the app-provided present start timestamp falls within the Present_Start → Present_Stop interval (with PC-latency keeping the prior heuristic behavior).
Changes:
- Extend
ExtractAppTimingData()to accept a present stop timestamp and a mode flag to select matching strategy. - Update call sites to pass Present_Stop time when attaching app timing data, and compute a stop bound for PC-latency attachment.
- Implement interval-based selection for non-PC-latency timing data (time-in-window match).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
PresentData/PresentMonTraceConsumer.hpp |
Updates ExtractAppTimingData() signature to include presentStopTime and a mode flag. |
PresentData/PresentMonTraceConsumer.cpp |
Passes present stop time into app-timing attachment and implements window-based timing-data selection logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
planetchili
approved these changes
Jun 5, 2026
Collaborator
planetchili
left a comment
There was a problem hiding this comment.
Looks good to me, great stuff!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating app provider attachment methodology. Instead of finding and attaching to the closest Present Start, will now attach to the Present where the app provided present start resides in the Present Start and Present End interval. Note this only used in the absence of the app frame it.