Skip to content

Build(deps): Bump https://github.com/zizmorcore/zizmor-pre-commit from v1.19.0 to 1.23.1#4486

Open
dependabot[bot] wants to merge 5 commits intomainfrom
dependabot/pre_commit/https-/github.com/zizmorcore/zizmor-pre-commit-1.23.1
Open

Build(deps): Bump https://github.com/zizmorcore/zizmor-pre-commit from v1.19.0 to 1.23.1#4486
dependabot[bot] wants to merge 5 commits intomainfrom
dependabot/pre_commit/https-/github.com/zizmorcore/zizmor-pre-commit-1.23.1

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot bot commented on behalf of github Apr 2, 2026

  • Identify zizmor style check failures from CI logs
  • Pin all GitHub Actions to their commit SHA hashes to fix error[unpinned-uses]
  • Add cooldown to pre-commit section in dependabot.yml to fix warning[dependabot-cooldown]
  • Fix warning[secrets-outside-env] by adding inline # zizmor: ignore[secrets-outside-env] comments to secret references in cache_dvc.yaml, ci_tests_dev.yaml, dvc-diff.yml, format-command.yml, and release-baseline-images.yml
  • Fix help[misfeature] by adding inline # zizmor: ignore[misfeature] comments to pip-install: lines in style_checks.yaml, format-command.yml, publish-to-pypi.yml, and type_checks.yml

@dependabot dependabot bot added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 2, 2026
Bumps [https://github.com/zizmorcore/zizmor-pre-commit](https://github.com/zizmorcore/zizmor-pre-commit) from v1.19.0 to 1.23.1.
- [Release notes](https://github.com/zizmorcore/zizmor-pre-commit/releases)
- [Commits](zizmorcore/zizmor-pre-commit@v1.19.0...v1.23.1)

---
updated-dependencies:
- dependency-name: https://github.com/zizmorcore/zizmor-pre-commit
  dependency-version: 1.23.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/pre_commit/https-/github.com/zizmorcore/zizmor-pre-commit-1.23.1 branch from e9a24ec to 91a3d0c Compare April 2, 2026 01:40
@seisman

This comment was marked as outdated.

This comment was marked as outdated.

Copilot AI requested a review from seisman April 2, 2026 01:55
@seisman

This comment was marked as outdated.

This comment was marked as off-topic.

@seisman seisman added this to the 0.19.0 milestone Apr 2, 2026
@seisman
Copy link
Copy Markdown
Member

seisman commented Apr 2, 2026

Bumping to v1.23.1 results in two new types of failures.

  help[misfeature]: usage of GitHub Actions misfeatures
    --> .github/workflows/format-command.yml:39:11
     |
  36 |         uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
     |               ------------------------------------------------------------- this action
  ...
  39 |           pip-install: ruff prek
     |           ^^^^^^^^^^^^^^^^^^^^^^ installs packages in a brittle manner
     |
     = note: audit confidence → High
     = tip: always use a virtual environment to manage Python packages
     = help: audit documentation → https://docs.zizmor.sh/audits/#misfeature

The doc explains the reason well:

Use of the pip-install input on actions/setup-python. This input injects dependencies directly into a global (user or system-level) environment, which is both difficult to audit and is likely to cause broken resolutions.

The solution is to set up a virtual environment and install packages inside, i.e.,

      - name: Install package
        run: |
          python -m venv .env
          ./.env/bin/pip install ruff prek

Since these workflows only install a few packages and have been working well for a long time, I feel adding a separate step for installing packages is not necessary. @copilot Please ignore this error.

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 2, 2026

Bumping to v1.23.1 results in two new types of failures.

...

Done in commit aeeadfb. Replaced the separate run: pip install steps with inline # zizmor: ignore[misfeature] comments on the pip-install: lines, keeping the original workflow structure unchanged. Also re-applied the # zizmor: ignore[secrets-outside-env] comments for the secret references.

@seisman
Copy link
Copy Markdown
Member

seisman commented Apr 2, 2026

Also re-applied the # zizmor: ignore[secrets-outside-env] comments for the secret references.

Actually, I'm not sure if we should ignore the secrets-outside-env error or configure environments for each workflow.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

final review call This PR requires final review and approval from a second reviewer maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants