fix(BlockTopology): Fixed call to checks on block surface boundaries by MelchiorSchuh · Pull Request #182 · Geode-solutions/OpenGeode-Inspector

MelchiorSchuh · 2026-06-17T13:36:14Z

No description provided.

github-actions · 2026-06-17T13:39:53Z

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 55 concern(s)

src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:119:10: warning: [readability-function-cognitive-complexity]

function 'create_graph' has cognitive complexity of 16 (threshold 10)

  119 |     void create_graph( const geode::BRep& brep,
      |          ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:127:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  127 |         for( const auto& line : brep.lines() )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:132:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  132 |         for( const auto& line : brep.lines() )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:136:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  136 |             for( const auto& incident_surface : brep.incidences( line ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:138:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  138 |                 for( const auto& boundary_line :
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:144:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  144 |                     if( const auto existing_edge = graph.edge_from_vertices(
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:147:25: note: +5, including nesting penalty of 4, nesting level increased to 5
  147 |                         if( surface_uuids_to_graph_edges
      |                         ^

src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:119:10: warning: [readability-function-size]

function 'create_graph' exceeds recommended size/complexity thresholds

  119 |     void create_graph( const geode::BRep& brep,
      |          ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:119:10: note: 5 parameters (threshold 4)

src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:163:32: warning: [readability-function-cognitive-complexity]

function 'find_not_boundary_surfaces' has cognitive complexity of 33 (threshold 10)

  163 |     std::vector< geode::uuid > find_not_boundary_surfaces(
      |                                ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:176:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  176 |         while( found_not_boundary_surface )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:179:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  179 |             for( const auto graph_vertex :
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:182:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  182 |                 if( graph->edges_around_vertex( graph_vertex ).empty() )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:193:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  193 |                 for( const auto& edge_around :
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:196:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  196 |                     if( surface_uuids_to_graph_edges
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:205:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  205 |                 if( !should_delete )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:209:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  209 |                 if( absl::c_contains( not_boundaries_surfaces, surface_id ) )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:213:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  213 |                 for( const auto& edge :
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:220:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  220 |             if( !absl::c_contains( to_delete, true ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:228:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  228 |             for( const auto& [surface_id, graph_edges] :
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:231:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  231 |                 for( const auto graph_edge : graph_edges )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:233:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  233 |                     if( old2new.at( graph_edge ) != geode::NO_ID )
      |                     ^

src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:374:13: warning: [performance-inefficient-vector-operation]

'emplace_back' is called inside a loop; consider pre-allocating the container capacity before the loop
```
  372 |         for( const auto& surface_list : linked_surfaces_list )
  373 |         {
  374 |             bounding_boxes.emplace_back(
      |             ^
```

src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:400:50: warning: [readability-function-cognitive-complexity]

function 'fuse_brep_surfaces_from_list' has cognitive complexity of 11 (threshold 10)

  400 |     std::unique_ptr< geode::PolygonalSurface3D > fuse_brep_surfaces_from_list(
      |                                                  ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:409:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  409 |         for( const auto& surface_id : surface_list )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:413:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  413 |             for( const auto polygon :
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:418:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  418 |                 for( auto& polygon_vertex : polygon_vertices )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:422:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  422 |                     if( !unique_vertices_to_polygonal_surface_vertices
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:432:21: note: +1, nesting level increased to 4
  432 |                     else
      |                     ^

src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:446:10: warning: [readability-function-cognitive-complexity]

function 'block_boundaries_are_closed' has cognitive complexity of 19 (threshold 10)

  446 |     bool block_boundaries_are_closed(
      |          ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:451:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  451 |         while( !to_process.empty() )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:456:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  456 |         if( linked_boundary_parts.size() < 2 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:462:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  462 |         if( !enclosing_surface_index )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:470:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  470 |         for( const auto surface_list_id :
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:473:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  473 |             if( surface_list_id == enclosing_surface_index.value() )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:477:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  477 |             for( const auto& surface_id :
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:481:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  481 |                 for( const auto vertex_id :
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:486:25: note: +4, including nesting penalty of 3, nesting level increased to 4
  486 |                         if( !geode::is_point_inside_closed_surface(
      |                         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:494:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  494 |                     catch( const geode::OpenGeodeException& )
      |                     ^

src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:532:53: warning: [readability-function-cognitive-complexity]

function 'string' has cognitive complexity of 11 (threshold 10)

  532 |     std::string BRepBlocksTopologyInspectionResult::string() const
      |                                                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:535:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  535 |         if( some_blocks_not_meshed.nb_issues() != 0 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:539:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  539 |         if( wrong_block_boundary_surface.nb_issues() != 0 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:543:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  543 |         if( blocks_not_linked_to_a_unique_vertex.nb_issues() != 0 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:548:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  548 |         if( blocks_with_not_closed_boundary_surfaces.nb_issues() != 0 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:553:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  553 |         if( model_boundaries_dont_form_a_closed_surface.nb_issues() != 0 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:558:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  558 |         if( unique_vertices_part_of_two_blocks_and_no_boundary_surface
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:567:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  567 |         if( unique_vertices_with_incorrect_block_cmvs_count.nb_issues() != 0 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:573:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  573 |         if( unique_vertices_linked_to_surface_with_wrong_relationship_to_blocks
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:582:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  582 |         if( unique_vertices_linked_to_a_single_and_invalid_surface.nb_issues()
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:589:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  589 |         if( unique_vertex_linked_to_multiple_invalid_surfaces.nb_issues() != 0 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:595:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  595 |         if( !message.empty() )
      |         ^

src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:635:9: warning: [readability-function-cognitive-complexity]

function 'unique_vertex_is_part_of_two_blocks_and_no_boundary_surface' has cognitive complexity of 20 (threshold 10)

  635 |         unique_vertex_is_part_of_two_blocks_and_no_boundary_surface(
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:640:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  640 |         if( block_uuids.size() != 2 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:644:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  644 |         for( const auto& block_uuid : block_uuids )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:646:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  646 |             if( !brep_.block( block_uuid ).is_active() )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:651:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  651 |         for( const auto& surface_cmv :
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:654:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  654 |             if( surface_cmv.component_id.type()
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:659:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  659 |             if( brep_.Relationships::is_boundary(
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:661:17: note: +1
  661 |                 && brep_.Relationships::is_boundary(
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:666:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  666 |             for( const auto& line_cmv :
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:669:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  669 |                 if( line_cmv.component_id.type()
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:674:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  674 |                 if( brep_.Relationships::is_boundary(
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:677:21: note: +1
  677 |                     && ( brep_.Relationships::is_boundary(
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:679:26: note: +1
  679 |                          || brep_.Relationships::is_boundary(
      |                          ^

src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:716:9: warning: [readability-function-cognitive-complexity]

function 'vertex_is_part_of_surface_with_wrong_relationships_to_block' has cognitive complexity of 13 (threshold 10)

  716 |         vertex_is_part_of_surface_with_wrong_relationships_to_block(
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:721:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  721 |         for( const auto& cmv :
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:724:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  724 |             if( cmv.component_id.type() != Surface3D::component_type_static()
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:725:17: note: +1
  725 |                 || !brep_.surface( cmv.component_id.id() ).is_active() )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:729:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  729 |             if( brep_.nb_incidences( cmv.component_id.id() ) >= 1
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:730:17: note: +1
  730 |                 && absl::c_contains(
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:741:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  741 |             if( brep_.nb_embeddings( cmv.component_id.id() ) >= 1
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:745:17: note: +1
  745 |                 && absl::c_contains( dangling_surface, cmv.component_id.id() ) )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:755:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  755 |             if( brep_.nb_incidences( cmv.component_id.id() ) < 1
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:757:17: note: +1
  757 |                 && !absl::c_contains(
      |                 ^

src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:774:29: warning: [readability-function-cognitive-complexity]

function 'vertex_is_part_of_invalid_single_surface' has cognitive complexity of 17 (threshold 10)

  774 |         BRepBlocksTopology::vertex_is_part_of_invalid_single_surface(
      |                             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:780:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  780 |         if( surface_uuids.size() != 1
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:781:13: note: +1
  781 |             || !brep_.surface( surface_uuids[0] ).is_active() )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:788:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  788 |         if( absl::c_contains( not_boundary_surfaces, surface_id ) )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:792:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  792 |         if( block_uuids.size() > 2 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:798:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  798 |         if( brep_.nb_embeddings( surface_id ) > 0 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:800:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  800 |             if( internal::brep_blocks_are_meshed( brep_ ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:802:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  802 |                 if( block_uuids.size() != 1 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:808:22: note: +1, nesting level increased to 3
  808 |                 else if( !brep_.Relationships::is_internal(
      |                      ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:818:9: note: +1, nesting level increased to 1
  818 |         else
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:820:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  820 |             for( const auto& block_id : block_uuids )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:822:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  822 |                 if( !brep_.Relationships::is_boundary( surface_id, block_id ) )
      |                 ^

src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:808:17: warning: [llvm-else-after-return]

do not use 'else' after 'return'

  808 |                 else if( !brep_.Relationships::is_internal(
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  809 |                              surface_id, block_uuids[0] ) )
      |                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  810 |                 {
      |                 ~
  811 |                     return absl::StrCat( "unique vertex ", unique_vertex_index,
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  812 |                         " is part of only one Surface, which is "
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  813 |                         "embedded, and one Block, but the Surface is "
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  814 |                         "not internal to the Block." );
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  815 |                 }
      |                 ~

src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:843:29: warning: [readability-function-cognitive-complexity]

function 'vertex_is_part_of_invalid_multiple_surfaces' has cognitive complexity of 17 (threshold 10)

  843 |         BRepBlocksTopology::vertex_is_part_of_invalid_multiple_surfaces(
      |                             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:848:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  848 |         if( line_uuids.size() < 2 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:854:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  854 |         if( surface_uuids.size() < 2 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:859:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  859 |         for( const auto& surface_uuid : surface_uuids )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:861:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  861 |             if( brep_.nb_incidences( surface_uuid ) < 1
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:862:17: note: +1
  862 |                 && brep_.nb_embeddings( surface_uuid ) < 1 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:868:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  868 |         if( not_dangling_surfaces.size() < 2 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:872:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  872 |         for( const auto& line_id : line_uuids )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:875:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  875 |             for( const auto& surface_id : not_dangling_surfaces )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:877:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  877 |                 if( !brep_.Relationships::is_internal( line_id, surface_id )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:878:21: note: +1
  878 |                     && !brep_.Relationships::is_boundary(
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:885:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  885 |             if( brep_.nb_embeddings( line_id ) < 1
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:888:17: note: +1
  888 |                 && line_has_relations_with_all_surfaces )
      |                 ^

src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:906:29: warning: [readability-function-cognitive-complexity]

function 'inspect_blocks' has cognitive complexity of 36 (threshold 10)

  906 |         BRepBlocksTopology::inspect_blocks() const
      |                             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:909:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  909 |         if( brep_.nb_active_blocks() == 0 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:918:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  918 |         for( const auto& block : brep_.active_blocks() )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:920:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  920 |             if( !block_is_meshed( brep_.block( block.id() ) ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:927:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  927 |         if( !blocks_not_meshed.empty() && !meshed_blocks.empty() )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:927:40: note: +1
  927 |         if( !blocks_not_meshed.empty() && !meshed_blocks.empty() )
      |                                        ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:929:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  929 |             for( const auto& block_id : blocks_not_meshed )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:939:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  939 |         for( const auto& meshed_block_id : meshed_blocks )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:945:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  945 |             if( block_result.nb_issues() != 0 )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:956:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  956 |         if( brep_.nb_model_boundaries() != 0 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:958:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  958 |             if( !brep_boundaries_are_closed( brep_ ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:964:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  964 |         for( const auto unique_vertex_id : Range{ brep_.nb_unique_vertices() } )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:966:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  966 |             if( const auto problem_message =
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:974:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  974 |             if( const auto problem_message =
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:981:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  981 |             if( const auto problem_message =
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:988:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  988 |             if( const auto problem_message =
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:997:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  997 |             if( const auto problem_message =
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:1005:9: note: +1, including nesting penalty of 0, nesting level increased to 1
 1005 |         for( const auto& block : brep_.active_blocks() )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:1007:13: note: +2, including nesting penalty of 1, nesting level increased to 2
 1007 |             if( !block_boundaries_are_closed( brep_, block ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:1017:13: note: +2, including nesting penalty of 1, nesting level increased to 2
 1017 |             for( const auto& surface : brep_.boundaries( block ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:1019:17: note: +3, including nesting penalty of 2, nesting level increased to 3
 1019 |                 if( !surface.is_active() )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_blocks_topology.cpp:1023:17: note: +3, including nesting penalty of 2, nesting level increased to 3
 1023 |                 if( surface_boundaries_are_not_linked_to_another_block_boundary(
      |                 ^

src/geode/inspector/inspection/topology/brep_lines_topology.cpp:164:28: warning: [readability-function-cognitive-complexity]

function 'vertex_is_part_of_invalid_embedded_line' has cognitive complexity of 17 (threshold 10)

  164 |         BRepLinesTopology::vertex_is_part_of_invalid_embedded_line(
      |                            ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:167:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  167 |         for( const auto& line_cmv :
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:170:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  170 |             if( line_cmv.component_id.type()
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:177:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  177 |             if( !line.is_active() )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:181:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  181 |             for( const auto& embedding : brep_.embeddings( line_id ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:183:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  183 |                 if( brep_.Relationships::is_boundary(
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:197:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  197 |                 if( embedding.type() == Block3D::component_type_static()
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:198:21: note: +1
  198 |                     && !internal::brep_blocks_are_meshed( brep_ ) )
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:202:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  202 |                 if( !absl::c_any_of(
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:204:25: note: nesting level increased to 3
  204 |                         [&embedding]( const ComponentMeshVertex& cmv ) {
      |                         ^

src/geode/inspector/inspection/topology/brep_lines_topology.cpp:225:28: warning: [readability-function-cognitive-complexity]

function 'vertex_is_part_of_invalid_single_line' has cognitive complexity of 23 (threshold 10)

  225 |         BRepLinesTopology::vertex_is_part_of_invalid_single_line(
      |                            ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:230:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  230 |         if( line_uuids.size() != 1 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:236:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  236 |         if( !line.is_active() )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:244:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  244 |         if( brep_.nb_embedding_surfaces( line ) < 1
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:245:13: note: +1
  245 |             && brep_.nb_incidences( line_id ) < 1 )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:249:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  249 |         if( surface_uuids.size() == 1 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:251:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  251 |             if( !brep_.Relationships::is_internal( line_id, surface_uuids[0] )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:252:17: note: +1
  252 |                 && !( brep_.Relationships::nb_embeddings( surface_uuids[0] ) > 0
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:253:23: note: +1
  253 |                       || brep_.Relationships::is_boundary(
      |                       ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:269:14: note: +1, nesting level increased to 1
  269 |         else if( surface_uuids.empty() )
      |              ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:271:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  271 |             if( !internal::brep_blocks_are_meshed( brep_ ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:275:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  275 |             if( block_uuids.size() != 1 )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:283:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  283 |             if( !brep_.Relationships::is_internal( line_id, block_uuids[0] ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:293:9: note: +1, nesting level increased to 1
  293 |         else
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:295:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  295 |             for( const auto& surface_id : surface_uuids )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:298:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  298 |                 if( !brep_.is_boundary( line, surface )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:299:21: note: +1
  299 |                     && !brep_.is_internal( line, surface ) )
      |                     ^

src/geode/inspector/inspection/topology/brep_lines_topology.cpp:252:20: warning: [readability-simplify-boolean-expr]

boolean expression can be simplified by DeMorgan's theorem

  252 |                 && !( brep_.Relationships::nb_embeddings( surface_uuids[0] ) > 0
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                                                              <=
  253 |                       || brep_.Relationships::is_boundary(
      |                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                       && !
  254 |                           line_id, surface_uuids[0] ) ) )
      |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/geode/inspector/inspection/topology/brep_lines_topology.cpp:316:9: warning: [readability-function-cognitive-complexity]

function 'vertex_is_part_of_line_with_wrong_relationships_to_surface' has cognitive complexity of 38 (threshold 10)

  316 |         vertex_is_part_of_line_with_wrong_relationships_to_surface(
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:319:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  319 |         for( const auto& cmv :
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:322:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  322 |             if( cmv.component_id.type() != Line3D::component_type_static() )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:327:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  327 |             if( !line.is_active() || line.mesh().nb_edges() == 0 )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:327:35: note: +1
  327 |             if( !line.is_active() || line.mesh().nb_edges() == 0 )
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:332:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  332 |             for( const auto& incident_surface : brep_.incidences( line ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:334:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  334 |                 if( !incident_surface.is_active() )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:338:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  338 |                 if( !cme.surface_edges.contains( incident_surface.id() ) )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:349:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  349 |                 if( cme.surface_edges.at( incident_surface.id() ).size() != 1 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:363:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  363 |             for( const auto& embedding_surface :
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:366:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  366 |                 if( !embedding_surface.is_active() )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:370:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  370 |                 if( !cme.surface_edges.contains( embedding_surface.id() ) )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:382:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  382 |                 if( cme.surface_edges.at( embedding_surface.id() ).size() <= 1 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:396:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  396 |             if( brep_.nb_incidences( cmv.component_id.id() ) == 0
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:397:17: note: +1
  397 |                 && brep_.nb_embedding_surfaces( line ) == 0 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:399:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  399 |                 for( const auto& [surface_id, _] : cme.surface_edges )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:401:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  401 |                     if( brep_.surface( surface_id ).is_active() )
      |                     ^

src/geode/inspector/inspection/topology/brep_lines_topology.cpp:448:28: warning: [readability-function-cognitive-complexity]

function 'line_edge_has_wrong_component_edges_around' has cognitive complexity of 36 (threshold 10)

  448 |         BRepLinesTopology::line_edge_has_wrong_component_edges_around(
      |                            ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:452:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  452 |         for( const auto& [surface_id, surface_edges] : cme.surface_edges )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:455:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  455 |             if( !surface.is_active() )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:459:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  459 |             if( brep_.is_boundary( line, surface ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:461:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  461 |                 if( surface_edges.size() != 1 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:473:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  473 |             if( brep_.is_internal( line, surface ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:475:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  475 |                 if( surface_edges.size() != 2 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:492:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  492 |         for( const auto& embedding_surface : brep_.embedding_surfaces( line ) )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:494:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  494 |             if( !embedding_surface.is_active() )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:498:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  498 |             if( !cme.surface_edges.contains( embedding_surface.id() ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:509:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  509 |         for( const auto& incident_surface : brep_.incidences( line ) )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:511:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  511 |             if( !incident_surface.is_active() )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:515:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  515 |             if( !cme.surface_edges.contains( incident_surface.id() ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:526:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  526 |         for( const auto& [block_id, block_edges] : cme.block_edges )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:529:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  529 |             if( block.is_active() && brep_.is_internal( line, block ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:529:35: note: +1
  529 |             if( block.is_active() && brep_.is_internal( line, block ) )
      |                                   ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:531:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  531 |                 if( block_edges.size() != 1 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:543:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  543 |         for( const auto& embedding_block : brep_.embedding_blocks( line ) )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:545:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  545 |             if( !embedding_block.is_active()
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:546:17: note: +1
  546 |                 || embedding_block.mesh().nb_polyhedra() == 0 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:550:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  550 |             if( !cme.block_edges.contains( embedding_block.id() ) )
      |             ^

src/geode/inspector/inspection/topology/brep_lines_topology.cpp:565:28: warning: [readability-function-cognitive-complexity]

function 'inspect_lines_topology' has cognitive complexity of 21 (threshold 10)

  565 |         BRepLinesTopology::inspect_lines_topology() const
      |                            ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:568:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  568 |         for( const auto& line : brep_.active_lines() )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:570:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  570 |             if( !line_is_meshed( brep_.line( line.id() ) ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:580:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  580 |             if( line_result.nb_issues() != 0 )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:594:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  594 |             for( const auto edge_id : Range{ line.mesh().nb_edges() } )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:596:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  596 |                 if( const auto problem_message =
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:604:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  604 |             if( line_edges_with_wrong_cme.nb_issues() != 0 )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:611:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  611 |         for( const auto unique_vertex_id : Range{ brep_.nb_unique_vertices() } )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:613:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  613 |             if( const auto invalid_internal_topology =
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:621:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  621 |             if( const auto problem_message =
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:629:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  629 |             if( const auto problem_message =
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/inspection/topology/brep_lines_topology.cpp:635:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  635 |             if( const auto lines_but_is_not_corner =
      |             ^

tests/inspection/test-brep.cpp:34:16: warning: [misc-use-internal-linkage]

function 'corners_topological_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   34 | geode::index_t corners_topological_validity(
      |                ^
      | static 
```
tests/inspection/test-brep.cpp:62:16: warning: [misc-use-internal-linkage]

function 'lines_topological_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   62 | geode::index_t lines_topological_validity(
      |                ^
      | static 
```
tests/inspection/test-brep.cpp:93:16: warning: [misc-use-internal-linkage]

function 'surfaces_topological_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
   93 | geode::index_t surfaces_topological_validity(
      |                ^
      | static 
```
tests/inspection/test-brep.cpp:122:16: warning: [misc-use-internal-linkage]

function 'blocks_topological_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  122 | geode::index_t blocks_topological_validity(
      |                ^
      | static 
```
tests/inspection/test-brep.cpp:157:16: warning: [misc-use-internal-linkage]

function 'launch_topological_validity_checks' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  157 | geode::index_t launch_topological_validity_checks(
      |                ^
      | static 
```
tests/inspection/test-brep.cpp:167:16: warning: [misc-use-internal-linkage]

function 'meshes_adjacencies_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  167 | geode::index_t meshes_adjacencies_validity(
      |                ^
      | static 
```
tests/inspection/test-brep.cpp:190:16: warning: [misc-use-internal-linkage]

function 'meshes_degenerations_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  190 | geode::index_t meshes_degenerations_validity(
      |                ^
      | static 
```
tests/inspection/test-brep.cpp:218:16: warning: [misc-use-internal-linkage]

function 'meshes_intersections_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  218 | geode::index_t meshes_intersections_validity(
      |                ^
      | static 
```

tests/inspection/test-brep.cpp:219:56: warning: [performance-unnecessary-value-param]

the const qualified parameter 'result' is copied for each invocation; consider making it a reference

  219 |     const geode::ElementsIntersectionsInspectionResult result, bool string )
      |                                                        ^
      |                                                       &

tests/inspection/test-brep.cpp:233:16: warning: [misc-use-internal-linkage]

function 'meshes_manifolds_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  233 | geode::index_t meshes_manifolds_validity(
      |                ^
      | static 
```
tests/inspection/test-brep.cpp:262:16: warning: [misc-use-internal-linkage]

function 'meshes_colocations_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  262 | geode::index_t meshes_colocations_validity(
      |                ^
      | static 
```
tests/inspection/test-brep.cpp:279:16: warning: [misc-use-internal-linkage]

function 'meshes_unique_vertices_validity' can be made static or moved into an anonymous namespace to enforce internal linkage
```
  279 | geode::index_t meshes_unique_vertices_validity(
      |                ^
      | static 
```

Have any feedback or feature suggestions? Share it here.

…m:Geode-solutions/OpenGeode-Inspector into fix/checks_on_block_boundaries-not_called

… into fix/checks_on_block_boundaries-not_called

BotellaA · 2026-06-22T08:55:10Z

🎉 This PR is included in version 6.11.1-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

BotellaA · 2026-06-23T01:06:19Z

🎉 This PR is included in version 6.11.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

fix(BlockTopology): Fixed call to checks on block surface boundaries

5836701

MelchiorSchuh requested a review from BotellaA June 17, 2026 13:36

Apply prepare changes

d1e4768

BotellaA approved these changes Jun 17, 2026

View reviewed changes

MelchiorSchuh added 6 commits June 17, 2026 17:00

fix boundary surfaces test

058ab8e

Merge branch 'fix/checks_on_block_boundaries-not_called' of github.co…

0a793ba

…m:Geode-solutions/OpenGeode-Inspector into fix/checks_on_block_boundaries-not_called

fix tests

0611057

fix test in case of inner blocks

e43c386

fix block boundaries test

c2eaa41

Merge branch 'next' of github.com:Geode-solutions/OpenGeode-Inspector…

2888de9

… into fix/checks_on_block_boundaries-not_called

BotellaA merged commit 7e83a8b into next Jun 22, 2026
20 checks passed

BotellaA deleted the fix/checks_on_block_boundaries-not_called branch June 22, 2026 08:46

BotellaA added the released on @next label Jun 22, 2026

BotellaA added the released label Jun 23, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(BlockTopology): Fixed call to checks on block surface boundaries#182

fix(BlockTopology): Fixed call to checks on block surface boundaries#182
BotellaA merged 8 commits into
nextfrom
fix/checks_on_block_boundaries-not_called

MelchiorSchuh commented Jun 17, 2026

Uh oh!

github-actions Bot commented Jun 17, 2026 •

edited

Loading

Uh oh!

Uh oh!

BotellaA commented Jun 22, 2026

Uh oh!

BotellaA commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

MelchiorSchuh commented Jun 17, 2026

Uh oh!

github-actions Bot commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Cpp-Linter Report ⚠️

Uh oh!

Uh oh!

BotellaA commented Jun 22, 2026

Uh oh!

BotellaA commented Jun 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Jun 17, 2026 •

edited

Loading