Introduce Claude skill to bump consumer projects#23
Conversation
WalkthroughAdds CLAUDE skill documentation for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (1)
.claude/skills/bump-conventions/SKILL.md (1)
12-45: LanguageTool: ensure “GitHub” capitalization is consistent.Static analysis reported an issue about the official name “GitHub” needing a capital “H” (hint references ~Line 43). Please scan for any occurrences of
github/gITHUB-like variants in this file and normalize to “GitHub”.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.claude/skills/bump-conventions/SKILL.md:
- Around line 33-35: Update the "Ask the user" step so the skill does not
persist full absolute filesystem paths into the `reference` memory; instead,
when prompting for the base directory (the step currently described as saving
"Android consumer SDK repos for the bump-conventions skill live under
`<path>`"), redact or store a non-identifying hint (e.g., only the last path
segment or a user-provided label) and explicitly request user consent before
saving any hint to `reference` memory, offering an opt-out that skips saving
entirely. Ensure the doc mentions the `reference` memory key name ("reference")
and the exact behavior (sanitize → confirm consent → save hint/skip) so
implementers of the skill know to change the prompt and storage logic
accordingly.
- Around line 82-83: The rule "If current == target for a repo, mark it as
already up to date and skip in the plan" must be tightened to require all
detected surfaces to match the target: treat Gradle plugin version and workflow
refs as separate "current" values and only consider a repo already up to date
when every detected surface/version equals the target; update the SKILL.md
sentence to explicitly list Gradle and workflow surfaces (or "all detected
surfaces/versions") and state that a mismatch on any one surface prevents
skipping the repo.
- Around line 76-82: Update the logic that computes "releases that fall between
current (exclusive) and the target (inclusive)" to explicitly detect
non‑monotonic/downgrade targets: if target < current (or resolves to an older
release) then abort or surface a clear prompt asking how to proceed instead of
producing an empty/incorrect list. Locate and change the section that implements
the between‑range selection (the text/logic around "releases that fall between
current...and the target...") to add a guard that compares semantic versions or
release dates, and either return a clear error/abort message or prompt the user
for confirmation before continuing.
- Around line 88-110: The top-level fenced code block in the SKILL.md template
lacks a language tag (triple backticks without a language), which triggers
MD040; update the opening fence for the plan block to use a language tag (e.g.,
change the opening ``` to ```markdown) so the block starting with "# Conventions
bump plan → vX.Y.Z" is declared as markdown and satisfies markdownlint.
- Around line 70-73: The current guidance uses the dangerous git command "git
checkout -B bump/conventions/<target> origin/<default-branch>" which can
overwrite an existing local branch; change the flow to first detect a local
branch ref for "bump/conventions/<target>" and abort/ask the user if it exists,
then create the branch with the non-overwriting command "git checkout -b
bump/conventions/<target> origin/<default-branch>" (or explicitly fail if it
exists) instead of using "git checkout -B"; ensure the documentation and the
branch-creation step reference the branch pattern "bump/conventions/<target>"
and the safer "git checkout -b" approach so we never auto-overwrite a local ref.
- Around line 60-61: The current step running git -C <repo> symbolic-ref
refs/remotes/origin/HEAD --short can fail with exit code 128 if origin/HEAD is
unset; update the doc and the logic around that command to catch failure and
fall back to a defined strategy (try 'develop', then 'main', then prompt the
user) instead of aborting, and clarify this behavior in the SKILL.md text next
to the symbolic-ref command and the subsequent fetch (git -C <repo> fetch
origin) so readers know the fallback order and that a prompt will be used when
neither branch exists.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: ec15f41a-2282-4e9d-bd02-294cffbcfc98
📒 Files selected for processing (1)
.claude/skills/bump-conventions/SKILL.md
28fb615 to
2dd2e57
Compare
Summary by CodeRabbit
bump-conventionsskill to plan version bumps across consumer SDK repositories.