feat(ui): channel page and floating UI#2748
Open
renefloor wants to merge 44 commits into
Open
Conversation
This reverts commit 8f3f336. # Conflicts: # packages/stream_chat_flutter/lib/src/channel/channel_page.dart
broken due to merge
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR introduces ready-to-use ChangesLibrary UI foundation and public surface
Sample app migration to scaffold primitives
Sequence Diagram(s)sequenceDiagram
participant User
rect rgba(100, 149, 237, 0.5)
Note over User,StreamChannelPage: Channel Page Entry
end
User->>StreamChannelPage: open channel
StreamChannelPage->>_ChannelPageBody: build(insets)
_ChannelPageBody->>StreamMessageListView: topPadding/bottomPadding + handlers
User->>StreamMessageComposer: type/reply/edit
StreamMessageComposer->>StreamMessageComposerController: setQuotedMessage / editMessage
StreamMessageComposer-->>_ChannelPageBody: focus requested
rect rgba(100, 200, 100, 0.5)
Note over User,StreamThreadPage: Thread Entry via threadBuilder
end
User->>StreamMessageListView: tap thread reply
StreamMessageListView->>StreamThreadPage: threadBuilder(message)
StreamThreadPage->>StreamMessageComposerController: init with parent
StreamThreadPage->>_ThreadBody: build(parent, insets)
_ThreadBody->>StreamMessageListView: thread config + topPadding/bottomPadding
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 3
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
packages/stream_chat_flutter/lib/src/message_input/stream_message_composer.dart (1)
433-470:⚠️ Potential issue | 🟠 Major | ⚡ Quick winMissing
composerLocationincopyWithmethod.The new
composerLocationfield is not included in thecopyWithmethod, breaking the expected API contract. Callers cannot override this field when copying props.🐛 Proposed fix to add missing parameter
MessageComposerProps copyWith({ void Function(Message)? onMessageSent, FutureOr<Message> Function(Message)? preMessageSending, StreamMessageComposerController? messageComposerController, FocusNode? focusNode, bool? disableAttachments, bool? canAlsoSendToChannelFromThread, bool? enableVoiceRecording, bool? sendVoiceRecordingAutomatically, AudioRecorderFeedback? voiceRecordingFeedback, UserMentionTileBuilder? userMentionsTileBuilder, ErrorListener? onError, int? attachmentLimit, List<AttachmentPickerType>? allowedAttachmentPickerTypes, Iterable<StreamAutocompleteTrigger>? customAutocompleteTriggers, bool? mentionAllAppUsers, bool? shouldKeepFocusAfterMessage, MessageValidator? validator, String? restorationId, bool? enableSafeArea, bool? enableMentionsOverlay, VoidCallback? onQuotedMessageCleared, OgPreviewFilter? ogPreviewFilter, MessageInputPlaceholderBuilder? placeholderBuilder, bool? useSystemAttachmentPicker, PollConfig? pollConfig, AttachmentPickerOptionsBuilder? attachmentPickerOptionsBuilder, OnAttachmentPickerResult? onAttachmentPickerResult, KeyEventPredicate? sendMessageKeyPredicate, KeyEventPredicate? clearQuotedMessageKeyPredicate, TextInputAction? textInputAction, TextInputType? keyboardType, TextCapitalization? textCapitalization, bool? autofocus, bool? autoCorrect, + ComposerLocation? composerLocation, }) { return MessageComposerProps( onMessageSent: onMessageSent ?? this.onMessageSent, preMessageSending: preMessageSending ?? this.preMessageSending, messageComposerController: messageComposerController ?? this.messageComposerController, focusNode: focusNode ?? this.focusNode, disableAttachments: disableAttachments ?? this.disableAttachments, canAlsoSendToChannelFromThread: canAlsoSendToChannelFromThread ?? this.canAlsoSendToChannelFromThread, enableVoiceRecording: enableVoiceRecording ?? this.enableVoiceRecording, sendVoiceRecordingAutomatically: sendVoiceRecordingAutomatically ?? this.sendVoiceRecordingAutomatically, voiceRecordingFeedback: voiceRecordingFeedback ?? this.voiceRecordingFeedback, userMentionsTileBuilder: userMentionsTileBuilder ?? this.userMentionsTileBuilder, onError: onError ?? this.onError, attachmentLimit: attachmentLimit ?? this.attachmentLimit, allowedAttachmentPickerTypes: allowedAttachmentPickerTypes ?? this.allowedAttachmentPickerTypes, customAutocompleteTriggers: customAutocompleteTriggers ?? this.customAutocompleteTriggers, mentionAllAppUsers: mentionAllAppUsers ?? this.mentionAllAppUsers, shouldKeepFocusAfterMessage: shouldKeepFocusAfterMessage ?? this.shouldKeepFocusAfterMessage, validator: validator ?? this.validator, restorationId: restorationId ?? this.restorationId, enableSafeArea: enableSafeArea ?? this.enableSafeArea, enableMentionsOverlay: enableMentionsOverlay ?? this.enableMentionsOverlay, onQuotedMessageCleared: onQuotedMessageCleared ?? this.onQuotedMessageCleared, ogPreviewFilter: ogPreviewFilter ?? this.ogPreviewFilter, placeholderBuilder: placeholderBuilder ?? this.placeholderBuilder, useSystemAttachmentPicker: useSystemAttachmentPicker ?? this.useSystemAttachmentPicker, pollConfig: pollConfig ?? this.pollConfig, attachmentPickerOptionsBuilder: attachmentPickerOptionsBuilder ?? this.attachmentPickerOptionsBuilder, onAttachmentPickerResult: onAttachmentPickerResult ?? this.onAttachmentPickerResult, sendMessageKeyPredicate: sendMessageKeyPredicate ?? this.sendMessageKeyPredicate, clearQuotedMessageKeyPredicate: clearQuotedMessageKeyPredicate ?? this.clearQuotedMessageKeyPredicate, textInputAction: textInputAction ?? this.textInputAction, keyboardType: keyboardType ?? this.keyboardType, textCapitalization: textCapitalization ?? this.textCapitalization, autofocus: autofocus ?? this.autofocus, autoCorrect: autoCorrect ?? this.autoCorrect, + composerLocation: composerLocation ?? this.composerLocation, ); }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/stream_chat_flutter/lib/src/message_input/stream_message_composer.dart` around lines 433 - 470, The copyWith method in MessageComposerProps is missing the new composerLocation field; update the copyWith signature to accept composerLocation and include it in the returned MessageComposerProps (e.g., composerLocation: composerLocation ?? this.composerLocation) alongside the other fields so callers can override composerLocation when copying props.sample_app/lib/pages/new_group_chat_screen.dart (1)
10-11:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAdd public API doc comment.
NewGroupChatScreenis a public widget but lacks documentation. As per coding guidelines, all public APIs must have doc comments.📝 Suggested doc comment
+/// A screen for selecting users to add to a new group chat. +/// +/// Users can search for platform members and select multiple participants +/// before proceeding to group details configuration. class NewGroupChatScreen extends StatefulWidget { const NewGroupChatScreen({super.key});🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@sample_app/lib/pages/new_group_chat_screen.dart` around lines 10 - 11, Add a public Dart doc comment for the NewGroupChatScreen widget: above the class declaration for NewGroupChatScreen, insert a /// comment that briefly describes the widget's purpose (e.g., creates a UI for creating a new group chat), documents its constructor parameters (if any, like key), and any important behavior or usage notes so it complies with the public API documentation guideline.Source: Coding guidelines
🧹 Nitpick comments (3)
packages/stream_chat_flutter/lib/src/message_input/stream_message_composer.dart (1)
979-984: 💤 Low valueDeprecated
axisAlignmentparameter usage.The
axisAlignmentparameter onSizeTransitionis deprecated. The comment acknowledges this, but consider migrating to the replacement API when available to avoid future deprecation warnings during builds.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/stream_chat_flutter/lib/src/message_input/stream_message_composer.dart` around lines 979 - 984, Replace the deprecated axisAlignment usage in the SizeTransition inside StreamMessageComposer: remove the "axisAlignment: -1" argument and instead pass an alignment value that preserves the original behavior (axisAlignment -1 -> top alignment) using the new "alignment" parameter (e.g., Alignment.topCenter or AlignmentDirectional.topStart) on the SizeTransition that wraps _buildInlineAttachmentPicker; update the SizeTransition invocation accordingly so the widget aligns the collapsing/expanding animation to the top without using the deprecated axisAlignment.packages/stream_chat_flutter/lib/src/channel/channel_header.dart (1)
134-136: ⚡ Quick winInconsistent documentation pattern for
appBarBehaviorfields acrossStreamChannelHeader,StreamChannelListHeader, andStreamBackButton.All three widgets document their
appBarBehaviorfield with boolean phrasing ("Whether X is floating") when the field is typed asAppBarBehavior?, not a boolean. The documentation should describe the parameter's purpose (controlling visual behavior) and mention the fallback to theme defaults. Consider unifying the wording acrosschannel_header.dart,channel_list_header.dart, andback_button.dart.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/stream_chat_flutter/lib/src/channel/channel_header.dart` around lines 134 - 136, Update the doc comments for the appBarBehavior field in StreamChannelHeader, StreamChannelListHeader, and StreamBackButton to stop using boolean phrasing and instead describe that appBarBehavior (type AppBarBehavior?) controls the header/back button visual/layout behavior (e.g., floating vs pinned) and that it falls back to the theme's default when null; make the wording consistent across the three files by using the same concise sentence describing purpose and null/theme fallback and reference the AppBarBehavior type in the comment.packages/stream_chat_flutter/lib/src/channel/channel_page.dart (1)
32-44: ⚡ Quick winPrefer
late finalnon-nullableFocusNodeto avoid force-unwraps.The
_focusNodefield is declared nullable but always initialized ininitStateand force-unwrapped at every usage site (lines 43, 50, 57). This pattern is fragile and could panic if lifecycle order changes. Declaring it aslate final FocusNodemakes the initialization contract explicit and eliminates the null-check overhead.♻️ Proposed refactor
- FocusNode? _focusNode; + late final FocusNode _focusNode; final _messageComposerController = StreamMessageComposerController(); `@override` void initState() { + super.initState(); _focusNode = FocusNode(); - super.initState(); } `@override` void dispose() { - _focusNode!.dispose(); + _focusNode.dispose(); super.dispose(); } void _reply(Message message) { _messageComposerController.quotedMessage = message; WidgetsBinding.instance.addPostFrameCallback((timeStamp) { - _focusNode!.requestFocus(); + _focusNode.requestFocus(); }); }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/stream_chat_flutter/lib/src/channel/channel_page.dart` around lines 32 - 44, The _focusNode field is declared nullable but always initialized in initState and force-unwrapped elsewhere; change its declaration to use non-nullable late final (late final FocusNode _focusNode) so initialization is explicit, keep _focusNode = FocusNode() inside initState, call _focusNode.dispose() in dispose, and remove any force-unwraps (!) where _focusNode is accessed (e.g., usages in the widget build and handlers).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@packages/stream_chat_flutter/lib/src/message_input/attachment_picker/options/stream_gallery_picker.dart`:
- Line 78: The permission-loading branch in stream_gallery_picker.dart returns
const SizedBox.expand() when !snapshot.hasData, but the project's Empty widget
builds const SizedBox.shrink(), so replace the expand with the shrink (or return
Empty()) in the permission/loading branch to avoid introducing an unintended
expanded blank area and layout shift; locate the conditional using
snapshot.hasData in the StreamGalleryPicker build method and update the returned
widget accordingly.
In
`@packages/stream_chat_flutter/lib/src/message_input/stream_message_composer.dart`:
- Around line 14-16: The constant _kPickerBodyHeight is unused dead code; either
remove the declaration or apply it as the fixed height for the inline attachment
picker UI—locate the picker implementation in stream_message_composer.dart (look
for the InlineAttachmentPicker or picker body widget inside
StreamMessageComposer/MessageComposer) and replace any hard-coded height values
or SizedBox/Container height with _kPickerBodyHeight, or delete the
_kPickerBodyHeight declaration if you choose not to standardize the height.
In `@sample_app/lib/routes/app_routes.dart`:
- Around line 48-72: The onChannelAvatarPressed handler can crash because
currentUserId may be null and channelMembers.firstWhere(...) will throw if no
match; update the logic in onChannelAvatarPressed to null-guard currentUserId
and safely find the other member (use collection's firstWhereOrNull or
firstWhere with orElse returning null) when computing otherUser from
channel.state?.members, and only navigate to Routes.CHAT_INFO_SCREEN when
otherUser is non-null; fallback to the GROUP_INFO_SCREEN path otherwise. Ensure
you import the collection helper if you use firstWhereOrNull.
---
Outside diff comments:
In
`@packages/stream_chat_flutter/lib/src/message_input/stream_message_composer.dart`:
- Around line 433-470: The copyWith method in MessageComposerProps is missing
the new composerLocation field; update the copyWith signature to accept
composerLocation and include it in the returned MessageComposerProps (e.g.,
composerLocation: composerLocation ?? this.composerLocation) alongside the other
fields so callers can override composerLocation when copying props.
In `@sample_app/lib/pages/new_group_chat_screen.dart`:
- Around line 10-11: Add a public Dart doc comment for the NewGroupChatScreen
widget: above the class declaration for NewGroupChatScreen, insert a /// comment
that briefly describes the widget's purpose (e.g., creates a UI for creating a
new group chat), documents its constructor parameters (if any, like key), and
any important behavior or usage notes so it complies with the public API
documentation guideline.
---
Nitpick comments:
In `@packages/stream_chat_flutter/lib/src/channel/channel_header.dart`:
- Around line 134-136: Update the doc comments for the appBarBehavior field in
StreamChannelHeader, StreamChannelListHeader, and StreamBackButton to stop using
boolean phrasing and instead describe that appBarBehavior (type AppBarBehavior?)
controls the header/back button visual/layout behavior (e.g., floating vs
pinned) and that it falls back to the theme's default when null; make the
wording consistent across the three files by using the same concise sentence
describing purpose and null/theme fallback and reference the AppBarBehavior type
in the comment.
In `@packages/stream_chat_flutter/lib/src/channel/channel_page.dart`:
- Around line 32-44: The _focusNode field is declared nullable but always
initialized in initState and force-unwrapped elsewhere; change its declaration
to use non-nullable late final (late final FocusNode _focusNode) so
initialization is explicit, keep _focusNode = FocusNode() inside initState, call
_focusNode.dispose() in dispose, and remove any force-unwraps (!) where
_focusNode is accessed (e.g., usages in the widget build and handlers).
In
`@packages/stream_chat_flutter/lib/src/message_input/stream_message_composer.dart`:
- Around line 979-984: Replace the deprecated axisAlignment usage in the
SizeTransition inside StreamMessageComposer: remove the "axisAlignment: -1"
argument and instead pass an alignment value that preserves the original
behavior (axisAlignment -1 -> top alignment) using the new "alignment" parameter
(e.g., Alignment.topCenter or AlignmentDirectional.topStart) on the
SizeTransition that wraps _buildInlineAttachmentPicker; update the
SizeTransition invocation accordingly so the widget aligns the
collapsing/expanding animation to the top without using the deprecated
axisAlignment.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 9e2a3f42-fca0-422a-96f1-7cd12e8d83ee
📒 Files selected for processing (40)
docs/docs_screenshots/pubspec.yamlmelos.yamlpackages/stream_chat_flutter/CHANGELOG.mdpackages/stream_chat_flutter/lib/src/channel/channel_header.dartpackages/stream_chat_flutter/lib/src/channel/channel_list_header.dartpackages/stream_chat_flutter/lib/src/channel/channel_page.dartpackages/stream_chat_flutter/lib/src/channel/thread_page.dartpackages/stream_chat_flutter/lib/src/components/avatar/stream_channel_avatar.dartpackages/stream_chat_flutter/lib/src/components/avatar/stream_user_avatar.dartpackages/stream_chat_flutter/lib/src/components/avatar/stream_user_avatar_group.dartpackages/stream_chat_flutter/lib/src/message_action/message_actions_builder.dartpackages/stream_chat_flutter/lib/src/message_input/attachment_picker/options/stream_gallery_picker.dartpackages/stream_chat_flutter/lib/src/message_input/stream_message_composer.dartpackages/stream_chat_flutter/lib/src/message_list_view/message_list_view.dartpackages/stream_chat_flutter/lib/src/misc/back_button.dartpackages/stream_chat_flutter/lib/src/scroll_view/channel_scroll_view/stream_channel_list_skeleton_loading.dartpackages/stream_chat_flutter/lib/src/scroll_view/photo_gallery/stream_photo_gallery.dartpackages/stream_chat_flutter/lib/src/scroll_view/thread_scroll_view/stream_thread_list_skeleton_loading.dartpackages/stream_chat_flutter/lib/src/stream_chat_configuration.dartpackages/stream_chat_flutter/lib/stream_chat_flutter.dartpackages/stream_chat_flutter/pubspec.yamlsample_app/lib/app.dartsample_app/lib/config/sample_app_config.dartsample_app/lib/config/sample_app_config_screen.dartsample_app/lib/pages/advanced_options_page.dartsample_app/lib/pages/channel_file_display_screen.dartsample_app/lib/pages/channel_list_page.dartsample_app/lib/pages/channel_media_display_screen.dartsample_app/lib/pages/channel_page.dartsample_app/lib/pages/chat_info_screen.dartsample_app/lib/pages/draft_list_page.dartsample_app/lib/pages/group_chat_details_screen.dartsample_app/lib/pages/group_info_screen.dartsample_app/lib/pages/new_chat_screen.dartsample_app/lib/pages/new_group_chat_screen.dartsample_app/lib/pages/pinned_messages_screen.dartsample_app/lib/pages/thread_list_page.dartsample_app/lib/pages/thread_page.dartsample_app/lib/routes/app_routes.dartsample_app/lib/widgets/channel_list.dart
💤 Files with no reviewable changes (2)
- sample_app/lib/pages/thread_page.dart
- sample_app/lib/pages/channel_page.dart
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
packages/stream_chat_flutter/lib/src/message_input/stream_message_composer.dart (2)
430-467:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAllow
copyWithto clearcomposerLocation.
nullmeans “fall back to the theme” at Lines 799-800 and 918-919, butcomposerLocation ?? this.composerLocationmakes that state unreachable once a copied props object has an explicit override.Proposed minimal fix
TextCapitalization? textCapitalization, bool? autofocus, bool? autoCorrect, ComposerLocation? composerLocation, + bool clearComposerLocation = false, }) { return MessageComposerProps( @@ textCapitalization: textCapitalization ?? this.textCapitalization, autofocus: autofocus ?? this.autofocus, autoCorrect: autoCorrect ?? this.autoCorrect, - composerLocation: composerLocation ?? this.composerLocation, + composerLocation: clearComposerLocation ? null : composerLocation ?? this.composerLocation, ); }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/stream_chat_flutter/lib/src/message_input/stream_message_composer.dart` around lines 430 - 467, The copyWith method uses the coalesce operator for composerLocation parameter, which prevents null values from being passed through and assigned. This makes it impossible to clear the composerLocation back to null (which should fall back to the theme) once an explicit override exists. Change the composerLocation assignment in the return statement of copyWith to use a pattern that distinguishes between "parameter not provided" and "parameter explicitly set to null", such as using a sentinel value or optional parameter pattern. This will allow callers to explicitly set composerLocation to null when desired.
927-987:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winKeep the picker panel inside the desktop drop target.
The
DropTargetnow wraps only the input pill, while_buildInlineAttachmentPickeris a sibling. When the picker is open, dropping files over the picker panel no longer calls_addAttachments; wrap the whole composer column in the drop target and keep the floating gradient scoped to the pill.Proposed restructuring
- final pill = DropTarget( + final pill = Focus( + skipTraversal: true, + onKeyEvent: _handleKeyPressed, + child: StreamChatMessageInput( + controller: controller, + currentUserId: currentUserId, + onAttachmentButtonPressed: widget.props.disableAttachments ? null : _onAttachmentButtonPressed, + isPickerOpen: _isPickerVisible, + placeholder: _buildPlaceholder(context), + focusNode: focusNode, + onSendPressed: sendMessage, + canAlsoSendToChannel: _shouldShowSendToChannelCheckbox(), + audioRecorderController: widget.props.enableVoiceRecording ? _audioRecorderController : null, + sendVoiceRecordingAutomatically: widget.props.sendVoiceRecordingAutomatically, + feedback: widget.props.voiceRecordingFeedback, + onQuotedMessageCleared: () { + _effectiveController.clearQuotedMessage(); + widget.props.onQuotedMessageCleared?.call(); + }, + textInputAction: widget.props.textInputAction, + keyboardType: widget.props.keyboardType, + textCapitalization: widget.props.textCapitalization, + autofocus: widget.props.autofocus, + autocorrect: widget.props.autoCorrect, + isFloating: isFloating, + ), + ); + + Widget withDropTarget(Widget child) => DropTarget( onDragDone: (details) async { final attachments = <Attachment>[]; for (final file in details.files) { attachments.add(await file.toAttachment(type: AttachmentType.file)); } if (attachments.isNotEmpty) _addAttachments(attachments); }, onDragEntered: (_) {}, onDragExited: (_) {}, - child: Focus( - skipTraversal: true, - onKeyEvent: _handleKeyPressed, - child: StreamChatMessageInput( - controller: controller, - currentUserId: currentUserId, - onAttachmentButtonPressed: widget.props.disableAttachments ? null : _onAttachmentButtonPressed, - isPickerOpen: _isPickerVisible, - placeholder: _buildPlaceholder(context), - focusNode: focusNode, - onSendPressed: sendMessage, - canAlsoSendToChannel: _shouldShowSendToChannelCheckbox(), - audioRecorderController: widget.props.enableVoiceRecording ? _audioRecorderController : null, - sendVoiceRecordingAutomatically: widget.props.sendVoiceRecordingAutomatically, - feedback: widget.props.voiceRecordingFeedback, - onQuotedMessageCleared: () { - _effectiveController.clearQuotedMessage(); - widget.props.onQuotedMessageCleared?.call(); - }, - textInputAction: widget.props.textInputAction, - keyboardType: widget.props.keyboardType, - textCapitalization: widget.props.textCapitalization, - autofocus: widget.props.autofocus, - autocorrect: widget.props.autoCorrect, - isFloating: isFloating, - ), - ), + child: child, ); return PopScope( canPop: !_isPickerVisible, onPopInvokedWithResult: (didPop, _) { if (!didPop) _hidePicker(); }, - child: Column( + child: withDropTarget(Column( mainAxisSize: MainAxisSize.min, // Reversed paint order so the pill (and its shadow) paints on top // of the picker panel. VerticalDirection.up keeps the pill visually // above the picker while making it the last-painted child. verticalDirection: VerticalDirection.up, @@ if (isFloating) _buildFloatingComposerBand(context, pill) else pill, ], - ), + )), );🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/stream_chat_flutter/lib/src/message_input/stream_message_composer.dart` around lines 927 - 987, The DropTarget is currently wrapping only the pill (StreamChatMessageInput), leaving the picker panel (_buildInlineAttachmentPicker) outside the drop target as a sibling. This means dragging files over the open picker won't trigger file attachment handling since it's not within the drop target's scope. Restructure the code by moving the DropTarget wrapper to encompass the entire Column that contains both the SizeTransition (which wraps _buildInlineAttachmentPicker) and the pill. Keep the gradient wrapping logic scoped to just the pill by preserving the conditional check for isFloating around _buildFloatingComposerBand so the gradient height still tracks only the pill and doesn't stretch when the picker opens or closes.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In
`@packages/stream_chat_flutter/lib/src/message_input/stream_message_composer.dart`:
- Around line 430-467: The copyWith method uses the coalesce operator for
composerLocation parameter, which prevents null values from being passed through
and assigned. This makes it impossible to clear the composerLocation back to
null (which should fall back to the theme) once an explicit override exists.
Change the composerLocation assignment in the return statement of copyWith to
use a pattern that distinguishes between "parameter not provided" and "parameter
explicitly set to null", such as using a sentinel value or optional parameter
pattern. This will allow callers to explicitly set composerLocation to null when
desired.
- Around line 927-987: The DropTarget is currently wrapping only the pill
(StreamChatMessageInput), leaving the picker panel
(_buildInlineAttachmentPicker) outside the drop target as a sibling. This means
dragging files over the open picker won't trigger file attachment handling since
it's not within the drop target's scope. Restructure the code by moving the
DropTarget wrapper to encompass the entire Column that contains both the
SizeTransition (which wraps _buildInlineAttachmentPicker) and the pill. Keep the
gradient wrapping logic scoped to just the pill by preserving the conditional
check for isFloating around _buildFloatingComposerBand so the gradient height
still tracks only the pill and doesn't stretch when the picker opens or closes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: eca2004c-04c1-4b08-830a-768f69b98373
📒 Files selected for processing (7)
packages/stream_chat_flutter/lib/src/channel/channel_header.dartpackages/stream_chat_flutter/lib/src/channel/channel_list_header.dartpackages/stream_chat_flutter/lib/src/channel/channel_page.dartpackages/stream_chat_flutter/lib/src/message_input/stream_message_composer.dartpackages/stream_chat_flutter/lib/src/misc/back_button.dartsample_app/lib/pages/new_group_chat_screen.dartsample_app/lib/routes/app_routes.dart
🚧 Files skipped from review as they are similar to previous changes (6)
- packages/stream_chat_flutter/lib/src/misc/back_button.dart
- sample_app/lib/pages/new_group_chat_screen.dart
- sample_app/lib/routes/app_routes.dart
- packages/stream_chat_flutter/lib/src/channel/channel_list_header.dart
- packages/stream_chat_flutter/lib/src/channel/channel_page.dart
- packages/stream_chat_flutter/lib/src/channel/channel_header.dart
…ery nit - Fix StreamChannelPage disposing its StreamMessageComposerController in dispose(); aligns it with StreamThreadPage and prevents a resource leak. Align init style: late + super.initState() first, matching the thread page. - Replace inline LinearGradient in _buildFloatingComposerBand with the shared streamFloatingFade() helper from stream_core_flutter; re-export the helper via stream_chat_flutter.dart. - Drop redundant top: 0 from StreamPhotoGallery default padding. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
# Conflicts: # docs/docs_screenshots/pubspec.yaml # melos.yaml # packages/stream_chat_flutter/CHANGELOG.md # packages/stream_chat_flutter/lib/src/message_input/stream_message_composer.dart # packages/stream_chat_flutter/lib/stream_chat_flutter.dart # packages/stream_chat_flutter/pubspec.yaml
Contributor
There was a problem hiding this comment.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/stream_chat_flutter/lib/src/channel/channel_header.dart (1)
151-164:⚠️ Potential issue | 🟠 Major | ⚡ Quick winResolve avatar floating state from the same header theme source used by
StreamAppBar.Line 151 computes
effectiveAppBarBehaviorfrom ambientStreamAppBarTheme, but this widget later appliesheaderThemeviaStreamAppBarTheme(data: headerTheme, ...). IfchannelHeaderTheme.style.behavioris set, avatar shadow state can mismatch the rendered app bar behavior.Suggested fix
- final effectiveAppBarBehavior = - style?.behavior ?? - StreamAppBarTheme.of(context).style?.behavior ?? - (StreamTheme.of(context).appStyle.isFloating ? .floating : .regular); + final effectiveAppBarBehavior = + style?.behavior ?? + headerTheme.style?.behavior ?? + StreamAppBarTheme.of(context).style?.behavior ?? + (StreamTheme.of(context).appStyle.isFloating ? .floating : .regular);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/stream_chat_flutter/lib/src/channel/channel_header.dart` around lines 151 - 164, The effectiveAppBarBehavior computation uses the ambient StreamAppBarTheme context, but the headerTheme applied later via StreamAppBarTheme(data: headerTheme, ...) can override this. If channelHeaderTheme.style.behavior is set, the showAvatarShadow state for _DefaultChannelAvatar may mismatch the actual rendered app bar behavior. Modify the logic that determines showAvatarShadow to resolve the floating state from the same headerTheme source that will be applied to StreamAppBar, ensuring the avatar shadow state always matches the app bar behavior that will actually be rendered.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/stream_chat_flutter/lib/src/channel/channel_header.dart`:
- Line 213: The const constructor _DefaultChannelAvatar exceeds the
120-character line length limit. Refactor the constructor by wrapping the
parameters across multiple lines, placing each parameter (required this.channel,
this.onPressed, and this.isFloating) on separate lines or grouping them
logically to ensure no single line exceeds 120 characters while maintaining
proper indentation and formatting.
In `@packages/stream_chat_flutter/lib/src/channel/channel_list_header.dart`:
- Line 137: The _DefaultUserAvatar constructor call on line 137 exceeds the 120
character line length limit. Break this constructor invocation across multiple
lines by placing each named parameter (client, onPressed, isFloating) on
separate lines with appropriate indentation. Apply the same line-breaking
approach to the similar constructor call on line 191 to ensure both lines comply
with the 120 character coding guideline.
- Around line 128-137: The effectiveAppBarBehavior derivation in the fallback
chain is missing the channelListHeaderTheme.style?.behavior reference. Update
the null coalescing chain starting at the effectiveAppBarBehavior assignment to
include channelListHeaderTheme.style?.behavior between style?.behavior and
StreamAppBarTheme.of(context).style?.behavior, ensuring the header theme's
behavior is considered before falling back to the context app style's floating
state. This will ensure the avatar floating visuals remain consistent with the
actual app bar behavior since the bar is rendered under StreamAppBarTheme(data:
headerTheme).
In `@packages/stream_chat_flutter/lib/stream_chat_flutter.dart`:
- Around line 4-18: The export statement for stream_core_flutter/chat.dart in
the lib/stream_chat_flutter.dart file currently uses a hide allowlist approach,
which exports everything by default and only hides specific items. This
conflicts with package guidelines that require using a show allowlist instead.
Replace the hide-based export with a show-based export that explicitly lists
only the types that should be exported from stream_core_flutter/chat.dart,
providing better control over the public API surface and ensuring consistency
with the coding guidelines for this file.
---
Outside diff comments:
In `@packages/stream_chat_flutter/lib/src/channel/channel_header.dart`:
- Around line 151-164: The effectiveAppBarBehavior computation uses the ambient
StreamAppBarTheme context, but the headerTheme applied later via
StreamAppBarTheme(data: headerTheme, ...) can override this. If
channelHeaderTheme.style.behavior is set, the showAvatarShadow state for
_DefaultChannelAvatar may mismatch the actual rendered app bar behavior. Modify
the logic that determines showAvatarShadow to resolve the floating state from
the same headerTheme source that will be applied to StreamAppBar, ensuring the
avatar shadow state always matches the app bar behavior that will actually be
rendered.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d5ef7494-8a39-4941-899f-d8133a3f1e47
📒 Files selected for processing (23)
docs/docs_screenshots/pubspec.yamlmelos.yamlpackages/stream_chat_flutter/CHANGELOG.mdpackages/stream_chat_flutter/lib/src/channel/channel_header.dartpackages/stream_chat_flutter/lib/src/channel/channel_list_header.dartpackages/stream_chat_flutter/lib/src/components/avatar/stream_channel_avatar.dartpackages/stream_chat_flutter/lib/src/components/avatar/stream_user_avatar.dartpackages/stream_chat_flutter/lib/src/components/avatar/stream_user_avatar_group.dartpackages/stream_chat_flutter/lib/src/message_action/message_actions_builder.dartpackages/stream_chat_flutter/lib/src/message_input/attachment_picker/options/stream_gallery_picker.dartpackages/stream_chat_flutter/lib/src/message_input/stream_message_composer.dartpackages/stream_chat_flutter/lib/src/message_list_view/message_list_view.dartpackages/stream_chat_flutter/lib/src/misc/back_button.dartpackages/stream_chat_flutter/lib/src/scroll_view/channel_scroll_view/stream_channel_list_skeleton_loading.dartpackages/stream_chat_flutter/lib/src/scroll_view/thread_scroll_view/stream_thread_list_skeleton_loading.dartpackages/stream_chat_flutter/lib/src/theme/message_composer_theme.dartpackages/stream_chat_flutter/lib/src/theme/message_composer_theme.g.theme.dartpackages/stream_chat_flutter/lib/src/theme/stream_chat_theme.dartpackages/stream_chat_flutter/lib/src/theme/stream_chat_theme.g.theme.dartpackages/stream_chat_flutter/lib/src/theme/themes.dartpackages/stream_chat_flutter/lib/stream_chat_flutter.dartpackages/stream_chat_flutter/pubspec.yamlsample_app/lib/app.dart
✅ Files skipped from review due to trivial changes (4)
- packages/stream_chat_flutter/lib/src/scroll_view/thread_scroll_view/stream_thread_list_skeleton_loading.dart
- packages/stream_chat_flutter/lib/src/theme/themes.dart
- packages/stream_chat_flutter/lib/src/theme/message_composer_theme.g.theme.dart
- packages/stream_chat_flutter/CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (7)
- sample_app/lib/app.dart
- packages/stream_chat_flutter/pubspec.yaml
- packages/stream_chat_flutter/lib/src/scroll_view/channel_scroll_view/stream_channel_list_skeleton_loading.dart
- packages/stream_chat_flutter/lib/src/message_action/message_actions_builder.dart
- packages/stream_chat_flutter/lib/src/misc/back_button.dart
- packages/stream_chat_flutter/lib/src/message_input/attachment_picker/options/stream_gallery_picker.dart
- packages/stream_chat_flutter/lib/src/message_list_view/message_list_view.dart
Contributor
There was a problem hiding this comment.
Caution
Inline review comments failed to post. This is likely due to GitHub's internal server error or limits when posting large numbers of comments. If you are seeing this consistently it is likely a permissions issue. Please check "Moderation" -> "Code review limits" under your organization settings.
Actionable comments posted: 4
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/stream_chat_flutter/lib/src/channel/channel_header.dart (1)
151-164:⚠️ Potential issue | 🟠 Major | ⚡ Quick winResolve avatar floating state from the same header theme source used by
StreamAppBar.Line 151 computes
effectiveAppBarBehaviorfrom ambientStreamAppBarTheme, but this widget later appliesheaderThemeviaStreamAppBarTheme(data: headerTheme, ...). IfchannelHeaderTheme.style.behavioris set, avatar shadow state can mismatch the rendered app bar behavior.Suggested fix
- final effectiveAppBarBehavior = - style?.behavior ?? - StreamAppBarTheme.of(context).style?.behavior ?? - (StreamTheme.of(context).appStyle.isFloating ? .floating : .regular); + final effectiveAppBarBehavior = + style?.behavior ?? + headerTheme.style?.behavior ?? + StreamAppBarTheme.of(context).style?.behavior ?? + (StreamTheme.of(context).appStyle.isFloating ? .floating : .regular);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/stream_chat_flutter/lib/src/channel/channel_header.dart` around lines 151 - 164, The effectiveAppBarBehavior computation uses the ambient StreamAppBarTheme context, but the headerTheme applied later via StreamAppBarTheme(data: headerTheme, ...) can override this. If channelHeaderTheme.style.behavior is set, the showAvatarShadow state for _DefaultChannelAvatar may mismatch the actual rendered app bar behavior. Modify the logic that determines showAvatarShadow to resolve the floating state from the same headerTheme source that will be applied to StreamAppBar, ensuring the avatar shadow state always matches the app bar behavior that will actually be rendered.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/stream_chat_flutter/lib/src/channel/channel_header.dart`:
- Line 213: The const constructor _DefaultChannelAvatar exceeds the
120-character line length limit. Refactor the constructor by wrapping the
parameters across multiple lines, placing each parameter (required this.channel,
this.onPressed, and this.isFloating) on separate lines or grouping them
logically to ensure no single line exceeds 120 characters while maintaining
proper indentation and formatting.
In `@packages/stream_chat_flutter/lib/src/channel/channel_list_header.dart`:
- Line 137: The _DefaultUserAvatar constructor call on line 137 exceeds the 120
character line length limit. Break this constructor invocation across multiple
lines by placing each named parameter (client, onPressed, isFloating) on
separate lines with appropriate indentation. Apply the same line-breaking
approach to the similar constructor call on line 191 to ensure both lines comply
with the 120 character coding guideline.
- Around line 128-137: The effectiveAppBarBehavior derivation in the fallback
chain is missing the channelListHeaderTheme.style?.behavior reference. Update
the null coalescing chain starting at the effectiveAppBarBehavior assignment to
include channelListHeaderTheme.style?.behavior between style?.behavior and
StreamAppBarTheme.of(context).style?.behavior, ensuring the header theme's
behavior is considered before falling back to the context app style's floating
state. This will ensure the avatar floating visuals remain consistent with the
actual app bar behavior since the bar is rendered under StreamAppBarTheme(data:
headerTheme).
In `@packages/stream_chat_flutter/lib/stream_chat_flutter.dart`:
- Around line 4-18: The export statement for stream_core_flutter/chat.dart in
the lib/stream_chat_flutter.dart file currently uses a hide allowlist approach,
which exports everything by default and only hides specific items. This
conflicts with package guidelines that require using a show allowlist instead.
Replace the hide-based export with a show-based export that explicitly lists
only the types that should be exported from stream_core_flutter/chat.dart,
providing better control over the public API surface and ensuring consistency
with the coding guidelines for this file.
---
Outside diff comments:
In `@packages/stream_chat_flutter/lib/src/channel/channel_header.dart`:
- Around line 151-164: The effectiveAppBarBehavior computation uses the ambient
StreamAppBarTheme context, but the headerTheme applied later via
StreamAppBarTheme(data: headerTheme, ...) can override this. If
channelHeaderTheme.style.behavior is set, the showAvatarShadow state for
_DefaultChannelAvatar may mismatch the actual rendered app bar behavior. Modify
the logic that determines showAvatarShadow to resolve the floating state from
the same headerTheme source that will be applied to StreamAppBar, ensuring the
avatar shadow state always matches the app bar behavior that will actually be
rendered.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d5ef7494-8a39-4941-899f-d8133a3f1e47
📒 Files selected for processing (23)
docs/docs_screenshots/pubspec.yamlmelos.yamlpackages/stream_chat_flutter/CHANGELOG.mdpackages/stream_chat_flutter/lib/src/channel/channel_header.dartpackages/stream_chat_flutter/lib/src/channel/channel_list_header.dartpackages/stream_chat_flutter/lib/src/components/avatar/stream_channel_avatar.dartpackages/stream_chat_flutter/lib/src/components/avatar/stream_user_avatar.dartpackages/stream_chat_flutter/lib/src/components/avatar/stream_user_avatar_group.dartpackages/stream_chat_flutter/lib/src/message_action/message_actions_builder.dartpackages/stream_chat_flutter/lib/src/message_input/attachment_picker/options/stream_gallery_picker.dartpackages/stream_chat_flutter/lib/src/message_input/stream_message_composer.dartpackages/stream_chat_flutter/lib/src/message_list_view/message_list_view.dartpackages/stream_chat_flutter/lib/src/misc/back_button.dartpackages/stream_chat_flutter/lib/src/scroll_view/channel_scroll_view/stream_channel_list_skeleton_loading.dartpackages/stream_chat_flutter/lib/src/scroll_view/thread_scroll_view/stream_thread_list_skeleton_loading.dartpackages/stream_chat_flutter/lib/src/theme/message_composer_theme.dartpackages/stream_chat_flutter/lib/src/theme/message_composer_theme.g.theme.dartpackages/stream_chat_flutter/lib/src/theme/stream_chat_theme.dartpackages/stream_chat_flutter/lib/src/theme/stream_chat_theme.g.theme.dartpackages/stream_chat_flutter/lib/src/theme/themes.dartpackages/stream_chat_flutter/lib/stream_chat_flutter.dartpackages/stream_chat_flutter/pubspec.yamlsample_app/lib/app.dart
✅ Files skipped from review due to trivial changes (4)
- packages/stream_chat_flutter/lib/src/scroll_view/thread_scroll_view/stream_thread_list_skeleton_loading.dart
- packages/stream_chat_flutter/lib/src/theme/themes.dart
- packages/stream_chat_flutter/lib/src/theme/message_composer_theme.g.theme.dart
- packages/stream_chat_flutter/CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (7)
- sample_app/lib/app.dart
- packages/stream_chat_flutter/pubspec.yaml
- packages/stream_chat_flutter/lib/src/scroll_view/channel_scroll_view/stream_channel_list_skeleton_loading.dart
- packages/stream_chat_flutter/lib/src/message_action/message_actions_builder.dart
- packages/stream_chat_flutter/lib/src/misc/back_button.dart
- packages/stream_chat_flutter/lib/src/message_input/attachment_picker/options/stream_gallery_picker.dart
- packages/stream_chat_flutter/lib/src/message_list_view/message_list_view.dart
🛑 Comments failed to post (4)
packages/stream_chat_flutter/lib/src/channel/channel_header.dart (1)
213-213:
⚠️ Potential issue | 🟡 Minor | ⚡ Quick winWrap the constructor parameters to satisfy the 120-char limit.
Line 213 exceeds the configured max line length.
As per coding guidelines, “
**/*.{dart,dart.bak}: Line length must not exceed 120 characters”.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/stream_chat_flutter/lib/src/channel/channel_header.dart` at line 213, The const constructor _DefaultChannelAvatar exceeds the 120-character line length limit. Refactor the constructor by wrapping the parameters across multiple lines, placing each parameter (required this.channel, this.onPressed, and this.isFloating) on separate lines or grouping them logically to ensure no single line exceeds 120 characters while maintaining proper indentation and formatting.Source: Coding guidelines
packages/stream_chat_flutter/lib/src/channel/channel_list_header.dart (2)
128-137:
⚠️ Potential issue | 🟠 Major | ⚡ Quick winInclude
channelListHeaderTheme.style.behaviorwhen deriving floating state.Lines 128-131 derive
effectiveAppBarBehaviorwithoutheaderTheme.style?.behavior, but the actual bar is rendered underStreamAppBarTheme(data: headerTheme). This can produce inconsistent avatar floating visuals vs app-bar behavior.Suggested fix
final effectiveAppBarBehavior = style?.behavior ?? + headerTheme.style?.behavior ?? StreamAppBarTheme.of(context).style?.behavior ?? (StreamTheme.of(context).appStyle.isFloating ? .floating : .regular);📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.final effectiveAppBarBehavior = style?.behavior ?? headerTheme.style?.behavior ?? StreamAppBarTheme.of(context).style?.behavior ?? (StreamTheme.of(context).appStyle.isFloating ? .floating : .regular); final hasAvatarShadow = switch (effectiveAppBarBehavior) { .floating => true, .regular => false, }; final leading = _DefaultUserAvatar(client: _client, onPressed: onUserAvatarPressed, isFloating: hasAvatarShadow);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/stream_chat_flutter/lib/src/channel/channel_list_header.dart` around lines 128 - 137, The effectiveAppBarBehavior derivation in the fallback chain is missing the channelListHeaderTheme.style?.behavior reference. Update the null coalescing chain starting at the effectiveAppBarBehavior assignment to include channelListHeaderTheme.style?.behavior between style?.behavior and StreamAppBarTheme.of(context).style?.behavior, ensuring the header theme's behavior is considered before falling back to the context app style's floating state. This will ensure the avatar floating visuals remain consistent with the actual app bar behavior since the bar is rendered under StreamAppBarTheme(data: headerTheme).
137-137:
⚠️ Potential issue | 🟡 Minor | ⚡ Quick winBreak long constructor calls across lines to stay within 120 chars.
Lines 137 and 191 exceed the line-length limit.
As per coding guidelines, “
**/*.{dart,dart.bak}: Line length must not exceed 120 characters”.Also applies to: 191-191
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/stream_chat_flutter/lib/src/channel/channel_list_header.dart` at line 137, The _DefaultUserAvatar constructor call on line 137 exceeds the 120 character line length limit. Break this constructor invocation across multiple lines by placing each named parameter (client, onPressed, isFloating) on separate lines with appropriate indentation. Apply the same line-breaking approach to the similar constructor call on line 191 to ensure both lines comply with the 120 character coding guideline.Source: Coding guidelines
packages/stream_chat_flutter/lib/stream_chat_flutter.dart (1)
4-18:
⚠️ Potential issue | 🟠 Major | 🏗️ Heavy liftUse a
showallowlist forstream_core_flutterexports instead ofhide.Line 4 switches to a broad export with selective
hide, which expands public-surface risk over time and conflicts with the package rule for this file.As per coding guidelines, “When adding new types from stream_core_flutter, add them to the show allowlist in lib/stream_chat_flutter.dart”.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/stream_chat_flutter/lib/stream_chat_flutter.dart` around lines 4 - 18, The export statement for stream_core_flutter/chat.dart in the lib/stream_chat_flutter.dart file currently uses a hide allowlist approach, which exports everything by default and only hides specific items. This conflicts with package guidelines that require using a show allowlist instead. Replace the hide-based export with a show-based export that explicitly lists only the types that should be exported from stream_core_flutter/chat.dart, providing better control over the public API surface and ensuring consistency with the coding guidelines for this file.Source: Coding guidelines
renefloor
force-pushed
the
feat/channel-page
branch
from
7bd0db2 to
38a0c59
Compare
renefloor
force-pushed
the
feat/channel-page
branch
from
93dcbac to
c8d7cf2
Compare
renefloor
force-pushed
the
feat/channel-page
branch
from
c8d7cf2 to
5730ff6
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2748 +/- ##
==========================================
- Coverage 69.48% 69.21% -0.28%
==========================================
Files 426 429 +3
Lines 25665 25834 +169
==========================================
+ Hits 17834 17880 +46
- Misses 7831 7954 +123 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submit a pull request
Linear: FLU-502
CLA
Description of the pull request
This introduces the floating style on all sample app pages and moves the channel page and thread page to the sdk.
The
StreamMessageListViewConfigurationis also added to the global chat config so it's easier to use in the channel and thread page.Core PR: GetStream/stream-core-flutter#115
Screenshots / Videos
Summary by CodeRabbit
New Features
StreamChannelPageandStreamThreadPagewith reply/edit flows, focus handling, and a themed typing indicator; re-exported from the main package entrypoint.ComposerLocation/MessageComposerProps.location, plus theme support.StreamMessageListViewnow accepts nullable per-widgetconfigplustopPadding/bottomPadding, backed by a default configuration in app settings.appBarBehaviorsupport for channel/thread headers and back button; floating avatar shadow now follows theme/behavior.Bug Fixes
StreamChannelPagenow disposes its composer controller; fixed redundant paddings in photo/skeleton galleries and improved attachment picker placeholder.