Skip to content

ci(repo): trigger conventional PR title check for v9 PRs#2764

Merged
xsahil03x merged 1 commit into
masterfrom
chore/ci-pr-title-v9-trigger
Jun 17, 2026
Merged

ci(repo): trigger conventional PR title check for v9 PRs#2764
xsahil03x merged 1 commit into
masterfrom
chore/ci-pr-title-v9-trigger

Conversation

@xsahil03x

@xsahil03x xsahil03x commented Jun 17, 2026

Copy link
Copy Markdown
Member

Summary

pull_request_target workflows are read from the default branch (master), not from the PR's base branch — this is a documented GitHub security behavior. The branches: filter on master's pr_title.yml was just [master], so PRs targeting v9 silently skipped both the conventional-PR-title and changelog-update gates.

#2756 added v9 to the same filter on the v9 branch, but that copy is never consulted for pull_request_target events; only master's version matters.

Confirmed via the runs API: comparing recent v9 backport PRs (#2760, #2763) shows check_db_entities (no branches: filter) ran, while PR is Conventional and Semantic did not.

Test plan

  • YAML still parses.
  • After merge, opening or editing the title of a v9 PR should trigger the PR is Conventional and Semantic check.

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

No user-facing changes in this release. Internal workflow configuration was updated.

pull_request_target workflows are read from the default branch (master),
not from the PR's base branch. The branches filter here was [master],
so PRs targeting v9 silently skipped the conventional-PR-title and
changelog-update gates (e.g. #2760, #2763).

PR #2756 added v9 to the same filter on the v9 branch, but that copy is
never consulted for pull_request_target.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ca6abded-c7c6-4073-b8f0-f640997cb592

📥 Commits

Reviewing files that changed from the base of the PR and between eb9dc89 and 544aa2a.

📒 Files selected for processing (1)
  • .github/workflows/pr_title.yml

📝 Walkthrough

Walkthrough

A single entry v9 is added to the types list of the pull_request_target trigger in .github/workflows/pr_title.yml. No other workflow logic, jobs, steps, or concurrency settings are modified.

Changes

PR Title Workflow Trigger

Layer / File(s) Summary
Add v9 to pull_request_target types
.github/workflows/pr_title.yml
v9 is appended to the existing types list (opened, edited) for the pull_request_target event trigger.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops in, makes a tiny addition,
v9 joins the list with quiet precision.
The workflow now listens for one more event,
A single line added, a small amendment.
🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding v9 to the PR title check trigger in the CI configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/ci-pr-title-v9-trigger

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xsahil03x xsahil03x enabled auto-merge (squash) June 17, 2026 14:07
@xsahil03x xsahil03x merged commit ce2c34e into master Jun 17, 2026
23 checks passed
@xsahil03x xsahil03x deleted the chore/ci-pr-title-v9-trigger branch June 17, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants