ci(repo): trigger conventional PR title check for v9 PRs#2764
Conversation
pull_request_target workflows are read from the default branch (master), not from the PR's base branch. The branches filter here was [master], so PRs targeting v9 silently skipped the conventional-PR-title and changelog-update gates (e.g. #2760, #2763). PR #2756 added v9 to the same filter on the v9 branch, but that copy is never consulted for pull_request_target. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA single entry ChangesPR Title Workflow Trigger
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
pull_request_targetworkflows are read from the default branch (master), not from the PR's base branch — this is a documented GitHub security behavior. Thebranches:filter on master'spr_title.ymlwas just[master], so PRs targetingv9silently skipped both the conventional-PR-title and changelog-update gates.#2756 added
v9to the same filter on the v9 branch, but that copy is never consulted forpull_request_targetevents; only master's version matters.Confirmed via the runs API: comparing recent v9 backport PRs (#2760, #2763) shows
check_db_entities(nobranches:filter) ran, whilePR is Conventional and Semanticdid not.Test plan
PR is Conventional and Semanticcheck.🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes
No user-facing changes in this release. Internal workflow configuration was updated.