Skip to content

chore(repo): bump min Flutter to 3.44.0 and Dart SDK to 3.12.0 - #2894

Draft
xsahil03x wants to merge 1 commit into
masterfrom
chore/flutter-3.44.0
Draft

chore(repo): bump min Flutter to 3.44.0 and Dart SDK to 3.12.0#2894
xsahil03x wants to merge 1 commit into
masterfrom
chore/flutter-3.44.0

Conversation

@xsahil03x

@xsahil03x xsahil03x commented Aug 14, 2026

Copy link
Copy Markdown
Member

Submit a pull request

Linear: FLU-694

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Flutter 3.47.0 went stable on 2026-08-12, so the SDK's "minimum supported = latest stable − 1" policy makes Flutter 3.44.0 / Dart 3.12.0 the new floor (up from 3.41.0 / 3.11.0).

This is Track B (floor raise) only — Track A ("support Flutter 3.47") already landed in #2882. Following #2721/#2108/#2068, a floor raise is not marked breaking: existing code keeps compiling, older SDKs simply stop resolving the new version, and the CHANGELOG bullets go under 🔄 Changed.

What changed

  • Three version knobs, in lockstep: melos.yaml (source of truth), .fvmrc, and legacy_version_analyze.yml's flutter_version — the last set to the new floor, since that job is the floor's regression test.
  • 13 pubspecs + the root workspace + pubspec.lock. stream_chat is pure Dart and correctly carries no flutter constraint.
  • prefer_initializing_formals on ~29 previously-silent sites. Raising the Dart constraint raises each package's language version, and Dart 3.12 legalised this._privateField as a named parameter — so the lint's suggested fix only became expressible now. Zero violations before, ~29 after; none of it caused by the new stable, all of it by the floor. Applied via dart fix --apply --code=prefer_initializing_formals.
  • CHANGELOG bullet in all five packages (stream_chat's mentions the Dart SDK only).

Manual review of the dart fix pass

dart fix is mechanical, not thoughtful, so the refactor was re-audited against current master:

  • No doc comment was rewritten or deleted (git diff -- '*.dart' | grep -E "^[-+]\s*(///|//)" is empty — checking only added lines would miss deletions).
  • No public parameter renamed. Every introduced this._foo traces to a removed _foo = foo;. Assignments whose names differ or carry a default — _provider = tokenProvider, _locationProvider = locationProvider ?? LocationProvider() — were correctly left alone.

Testing

Check Result
dart analyze --fatal-infos, 7 packages @ 3.44.0 (new floor) clean
same @ 3.47.0 (what CI's analyze job resolves to) clean
dart format, 1004 tracked files, both toolchains 0 changed
stream_chat / _core / _persistence / _localizations tests 1624 / 362 / 302 / 23 passed
stream_chat_flutter goldens (CI=true) 40 failed — identical set to master

On the 40 golden failures: these are the pre-existing macOS-vs-Linux baseline (committed goldens are Linux-rendered). origin/master was bootstrapped in a throwaway worktree under the same 3.44.0 toolchain and the failure sets diffed — comm returns empty in both directions, 40 shared. Zero introduced, so no goldens were regenerated and update_goldens.yml was not dispatched. No .png is touched by this diff.

Not verified locally: the build (android) and build (ios) matrix jobs — this PR's own CI run is the check there. Since this is a floor raise and not a new-stable adoption, no Gradle/AGP/Kotlin/Xcode floors move.

Out of scope (pre-existing, noted for follow-up)

  • avoid_null_checks_in_equality_operators in the root analysis_options.yaml reports deprecated_lint on both 3.44 and 3.47. Pre-existing debt, not introduced here — but cheaper to delete now than to hit as a hard undefined_lint failure two releases later. Worth a small follow-up PR.
  • melos bootstrap strips a stale jni entry from two example generated_plugins.cmake files (dead since media_kit's removal in fix(ui): Removed mediakit dependency from sdk #2828). Confirmed pre-existing — master's CI is green — so it is deliberately left out of this PR.

Screenshots / Videos

Not applicable — no user-visible behaviour or rendering changes.

🤖 Generated with Claude Code

Per the SDK's "minimum supported = latest stable - 1" policy, Flutter
3.47.0 shipping on 2026-08-12 makes 3.44.0 (Dart 3.12.0) the new floor.
Following #2721/#2108/#2068, a floor raise is not marked breaking:
existing code keeps compiling, older SDKs simply stop resolving the new
version, and the CHANGELOG bullet goes under Changed rather than
Breaking.

Moves the three version knobs that must stay in lockstep — melos.yaml
(source of truth), .fvmrc, and legacy_version_analyze.yml's
flutter_version — plus the 13 pubspecs melos propagates to.

Raising the Dart constraint also raises each package's language version,
which activated `prefer_initializing_formals` on previously-silent
sites: Dart 3.12 legalised `this._privateField` as a named parameter, so
the lint's suggested fix only became expressible now. Applied via
`dart fix --apply --code=prefer_initializing_formals`, verified by hand:

- No doc comment was rewritten or dropped by the refactor.
- Every introduced `this._foo` replaced a parameter named exactly `foo`,
  so no public call site changes. Assignments whose names differ or
  carry a default (`_provider = tokenProvider`, `_locationProvider =
  locationProvider ?? LocationProvider()`) were correctly left alone.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: f03ddb1d-3961-4771-9466-6e704128fb6e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant