chore(repo): bump min Flutter to 3.44.0 and Dart SDK to 3.12.0 - #2894
Draft
xsahil03x wants to merge 1 commit into
Draft
chore(repo): bump min Flutter to 3.44.0 and Dart SDK to 3.12.0#2894xsahil03x wants to merge 1 commit into
xsahil03x wants to merge 1 commit into
Conversation
Per the SDK's "minimum supported = latest stable - 1" policy, Flutter 3.47.0 shipping on 2026-08-12 makes 3.44.0 (Dart 3.12.0) the new floor. Following #2721/#2108/#2068, a floor raise is not marked breaking: existing code keeps compiling, older SDKs simply stop resolving the new version, and the CHANGELOG bullet goes under Changed rather than Breaking. Moves the three version knobs that must stay in lockstep — melos.yaml (source of truth), .fvmrc, and legacy_version_analyze.yml's flutter_version — plus the 13 pubspecs melos propagates to. Raising the Dart constraint also raises each package's language version, which activated `prefer_initializing_formals` on previously-silent sites: Dart 3.12 legalised `this._privateField` as a named parameter, so the lint's suggested fix only became expressible now. Applied via `dart fix --apply --code=prefer_initializing_formals`, verified by hand: - No doc comment was rewritten or dropped by the refactor. - Every introduced `this._foo` replaced a parameter named exactly `foo`, so no public call site changes. Assignments whose names differ or carry a default (`_provider = tokenProvider`, `_locationProvider = locationProvider ?? LocationProvider()`) were correctly left alone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submit a pull request
Linear: FLU-694
CLA
Description of the pull request
Flutter 3.47.0 went stable on 2026-08-12, so the SDK's "minimum supported = latest stable − 1" policy makes Flutter 3.44.0 / Dart 3.12.0 the new floor (up from 3.41.0 / 3.11.0).
This is Track B (floor raise) only — Track A ("support Flutter 3.47") already landed in #2882. Following #2721/#2108/#2068, a floor raise is not marked breaking: existing code keeps compiling, older SDKs simply stop resolving the new version, and the CHANGELOG bullets go under
🔄 Changed.What changed
melos.yaml(source of truth),.fvmrc, andlegacy_version_analyze.yml'sflutter_version— the last set to the new floor, since that job is the floor's regression test.pubspec.lock.stream_chatis pure Dart and correctly carries noflutterconstraint.prefer_initializing_formalson ~29 previously-silent sites. Raising the Dart constraint raises each package's language version, and Dart 3.12 legalisedthis._privateFieldas a named parameter — so the lint's suggested fix only became expressible now. Zero violations before, ~29 after; none of it caused by the new stable, all of it by the floor. Applied viadart fix --apply --code=prefer_initializing_formals.stream_chat's mentions the Dart SDK only).Manual review of the
dart fixpassdart fixis mechanical, not thoughtful, so the refactor was re-audited against currentmaster:git diff -- '*.dart' | grep -E "^[-+]\s*(///|//)"is empty — checking only added lines would miss deletions).this._footraces to a removed_foo = foo;. Assignments whose names differ or carry a default —_provider = tokenProvider,_locationProvider = locationProvider ?? LocationProvider()— were correctly left alone.Testing
dart analyze --fatal-infos, 7 packages @ 3.44.0 (new floor)analyzejob resolves to)dart format, 1004 tracked files, both toolchainsstream_chat/_core/_persistence/_localizationstestsstream_chat_fluttergoldens (CI=true)masterOn the 40 golden failures: these are the pre-existing macOS-vs-Linux baseline (committed goldens are Linux-rendered).
origin/masterwas bootstrapped in a throwaway worktree under the same 3.44.0 toolchain and the failure sets diffed —commreturns empty in both directions, 40 shared. Zero introduced, so no goldens were regenerated andupdate_goldens.ymlwas not dispatched. No.pngis touched by this diff.Not verified locally: the
build (android)andbuild (ios)matrix jobs — this PR's own CI run is the check there. Since this is a floor raise and not a new-stable adoption, no Gradle/AGP/Kotlin/Xcode floors move.Out of scope (pre-existing, noted for follow-up)
avoid_null_checks_in_equality_operatorsin the rootanalysis_options.yamlreportsdeprecated_linton both 3.44 and 3.47. Pre-existing debt, not introduced here — but cheaper to delete now than to hit as a hardundefined_lintfailure two releases later. Worth a small follow-up PR.melos bootstrapstrips a stalejnientry from two examplegenerated_plugins.cmakefiles (dead since media_kit's removal in fix(ui): Removed mediakit dependency from sdk #2828). Confirmed pre-existing —master's CI is green — so it is deliberately left out of this PR.Screenshots / Videos
Not applicable — no user-visible behaviour or rendering changes.
🤖 Generated with Claude Code