[Enhancement]Prevent WebSocket reconnection with expired tokens - #70
Draft
ipavlidakis wants to merge 2 commits into
Draft
[Enhancement]Prevent WebSocket reconnection with expired tokens#70ipavlidakis wants to merge 2 commits into
ipavlidakis wants to merge 2 commits into
Conversation
Generated by 🚫 Danger |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Separates token-refresh recovery from automatic WebSocket reconnection.
When a WebSocket disconnects because its token expired, StreamCore now waits for the owning SDK to refresh the token and reconnect explicitly instead of retrying with the existing credentials.
Motivation
An expired token was previously considered automatically reconnectable. This allowed
DefaultConnectionRecoveryHandlerto callconnect()while StreamChat or StreamVideo was still refreshing the token.That created a race where the WebSocket could reconnect using stale credentials.
Changes
WebSocketConnectionState.requiresTokenRefresh.ConnectionStatusas.connectingwhile token refresh is required.Recovery contract
connect().