[CPF] Port SVGView to FoundationEssentials#17
Conversation
464b281 to
d8fecbd
Compare
| #elseif !canImport(CoreGraphics) | ||
| public typealias CGFloat = Double | ||
|
|
||
| public struct CGPoint: Equatable { |
There was a problem hiding this comment.
Initially I wanted to separate these in another repo since it's reusable. But, this repo is public and I can't make this thing public without legal approval so this is the best I can do
619414a to
233fb0d
Compare
| .package( | ||
| url: "https://github.com/compnerd/xylem.git", | ||
| revision: "9881c95ce3a139f4ccfa584676201516c2a5751d" | ||
| ), |
There was a problem hiding this comment.
Pointing to a specific rev might be an issue with some internal tooling we have about the SPM registry, but since we are not actively using it ATM we can revisit this problem later, hopefully xylem cuts a version soon.
There was a problem hiding this comment.
You're right. I already faced this now
error: Dependencies could not be resolved because package 'svgview' is required using a stable-version but 'svgview' depends on an unstable-version package 'xylem' and 'svgtonotesitems' depends on 'svgview' 0.2.20-goodnotes-foundation-essentials.
|
It's a pretty big PR, thanks @0xpablo for reviewing this really quickly! I'm going to merge this now but feel free to still leave any comments. This won't be live until I merge https://github.com/GoodNotes/GoodNotes-5/pull/62778 anyway |
Summary
Validation
swift testDOMParserandSVGParser