feat: Add UI support for RSS notification channels#2441
Merged
Conversation
jcscottiii
approved these changes
Apr 21, 2026
…system channels This change implements the storage layer requirements for the Intent-Based RSS notification architecture. - Expose ChannelType in Subscriptions: Updated SavedSearchSubscriptionView to include ChannelType by joining with NotificationChannels in SelectOne and SelectList queries. This allows the API to return the channel type (e.g., 'rss') in subscription responses without extra lookups. - Protect System Channels: Updated Get, Update, and Delete NotificationChannel methods to enforce that system-managed channels (like RSS) cannot be accessed or modified directly by users. - Allow System Channels for Subscriptions: Updated createSavedSearchSubscription to allow linking to system channels during ownership checks. - Fixed tests and lints: Resolved UUID type mismatches in backend_test.go and added ChannelType to struct literals to satisfy the exhaustruct linter.
…sed RSS This change implements the server layer requirements for the Intent-Based RSS notification architecture. - XOR Validation in CreateSubscription: Enforced that exactly one of 'channel_id' (Explicit Mode) or 'channel_type' (Implicit Mode) must be provided in CreateSubscription requests. - Hiding RSS Channels: Ensured that system-managed RSS channels are not exposed in list responses or directly accessible via CRUD operations (returning 404). - Hardening Create Notification Channel: Updated handler to explicitly reject manual creation of 'rss' channels, forcing users to use the intent-based subscription API. - Updated tests to reflect the new behavior and verify validation rules.
neilv-g
force-pushed
the
neilv-rss-final-5
branch
from
12d365b to
ffe07ff
Compare
Move from manual RSS channel management to implicit when subscribing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I won't be merging this change in until all backend PRs are complete/have landed. Just raising the PR early.