fix: validate web feature entries#2520
Open
nanookclaw wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #510.
This adds a validation step inside
V3Parser.Parsebefore the existing post-processing logic runs. The validator checks the rawfeaturesobject fromdata.jsonso malformed entries fail closed instead of being silently skipped or ingested with empty display data.The checks now reject missing/empty feature maps, empty feature IDs, malformed feature values, unknown or missing
kinddiscriminators, andkind: "feature"entries whosenameis missing or blank. I left release-version handling in the existing workflow layer:parseByVersionalready gates parser selection from the GitHub release tag, and the current upstreamdata.jsondoes not include a top-level version field.The post-processing switch now returns an error for bad discriminator data as a second guard, and feature processing rejects empty names before constructing the stored feature value.
Verification
make jsonschemato generate ignored local schema code needed for testsGOTOOLCHAIN=go1.26.0 go test -count=1 ./pkg/datagit diff --check