appengine: keep auth_domain as hashicorptest.com in TestAccAppEngineApplication_basic update - #18754
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a46af4b: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @SirGitsalot VCR tests complete for a46af4b! |
…pplication_basic update
a46af4b to
b391b21
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b391b21: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @SirGitsalot VCR tests complete for b391b21! |
Fixes nightly acceptance test failure for
TestAccAppEngineApplication_basic.Root Cause & Fix
In
TestAccAppEngineApplication_basic, the update step previously changedauth_domainfrom"hashicorptest.com"to"tf-test.club". Updatingauth_domaintriggers an invalid update request in test environments.This change keeps
auth_domainset to"hashicorptest.com"in the update step inmmv1/third_party/terraform/services/appengine/resource_app_engine_application_test.go.