fix(dataproc): add robust error handling for quota exhaustion#4351
Open
angelcaamal wants to merge 3 commits into
Open
fix(dataproc): add robust error handling for quota exhaustion#4351angelcaamal wants to merge 3 commits into
angelcaamal wants to merge 3 commits into
Conversation
angelcaamal
added
the
api: dataproc
product-auto-label
Bot
added
the
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces error handling in Dataproc system tests to gracefully skip execution when quota limits, resource exhaustion, or disk limits are encountered. The reviewer pointed out that skipping cluster creation will cause the corresponding after cleanup hooks to fail with NOT_FOUND errors when attempting to delete the non-existent cluster. It is recommended to wrap the cleanup logic in try-catch blocks to safely ignore these errors.
amcolin
approved these changes
Jun 19, 2026
amcolin
left a comment
amcolin
left a comment
Contributor
There was a problem hiding this comment.
Changes look good to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improve test suite robustness against quota and infrastructure errors
Key Changes
DISKS_TOTAL_GBquota exhaustionFixes Internal: b/525842927
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test(see Testing)npm run lint(see Style)GoogleCloudPlatform/nodejs-docs-samples. Not a fork.