Skip to content

chore: bump helm version#2106

Merged
google-oss-prow[bot] merged 2 commits intoGoogleContainerTools:mainfrom
tiffanny29631:helm
Mar 24, 2026
Merged

chore: bump helm version#2106
google-oss-prow[bot] merged 2 commits intoGoogleContainerTools:mainfrom
tiffanny29631:helm

Conversation

@tiffanny29631
Copy link
Copy Markdown
Contributor

Also modified the update script to sync the version in tool_utils.

@google-oss-prow google-oss-prow bot requested review from cowsking and janetkuo March 24, 2026 00:42
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on maintaining consistency and automation within the project's dependency management. It updates the Helm version to a newer gke release and, more significantly, introduces logic to the component update script to ensure that the recommended CLI versions defined in tool_util.go are automatically kept in sync with the versions specified in the Makefile during updates. This change streamlines the process of updating tool versions and reduces the potential for discrepancies.

Highlights

  • Helm Version Bump: The Helm version has been updated from v3.20.0-gke.1 to v3.20.0-gke.2 in both the Makefile and the pkg/hydrate/tool_util.go file.
  • Automated Version Sync: The scripts/update-component-image.sh script was enhanced to automatically synchronize the HelmVersion and KustomizeVersion constants within pkg/hydrate/tool_util.go whenever the respective components are updated.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the Helm version and updates the update-component-image.sh script to automatically synchronize this version in pkg/hydrate/tool_util.go. This is a good improvement for maintainability. However, the new sed commands in the script do not account for leading whitespace in the Go source file, which will cause the update to fail. I've provided a suggestion to make the script more robust.

Comment thread scripts/update-component-image.sh
@tiffanny29631 tiffanny29631 requested review from Camila-B and removed request for janetkuo March 24, 2026 00:48
Also modified the update script to sync the version in tool_utils.
@tiffanny29631
Copy link
Copy Markdown
Contributor Author

/retest-required

1 similar comment
@tiffanny29631
Copy link
Copy Markdown
Contributor Author

/retest-required

Copy link
Copy Markdown
Contributor

@cowsking cowsking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tiffanny29631
Copy link
Copy Markdown
Contributor Author

/hold

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@google-oss-prow google-oss-prow bot removed the lgtm label Mar 24, 2026
@tiffanny29631
Copy link
Copy Markdown
Contributor Author

/unhold

Copy link
Copy Markdown
Contributor

@Camila-B Camila-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Camila-B, cowsking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2c52847 into GoogleContainerTools:main Mar 24, 2026
7 checks passed
Camila-B pushed a commit to Camila-B/kpt-config-sync that referenced this pull request Apr 6, 2026
* chore: bump helm and otelcontribcol version

Also modified the update script to sync the version in tool_utils.

* Update scripts/update-component-image.sh

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants