Skip to content

Cleanups #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Goooler merged 5 commits into from
Jun 23, 2026
+5 −6
Merged

Cleanups #2064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e3ae2d6
Suppress UnstableApiUsage for addVariantsFromConfiguration
Goooler Jun 23, 2026
fb8e63a
Run check-links job on ubuntu-24.04-arm
Goooler Jun 23, 2026
2416e59
Tweak the snippet for KMP
Goooler Jun 23, 2026
32ec66a
Use latest in versions
Goooler Jun 23, 2026
aa4f09e
Revert "Use latest in versions"
Goooler Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/links.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ on:

jobs:
check-links:
runs-on: ubuntu-latest # TODO: https://github.com/UmbrellaDocs/linkspector/issues/149
runs-on: ubuntu-24.04-arm
if: github.event.repository.fork == false
steps:
- uses: actions/checkout@v7
Expand Down
5 changes: 2 additions & 3 deletions docs/kotlin-plugins/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,18 +80,17 @@ automatically configure additional tasks for bundling the shadowed JAR for its `
val ktorVersion = "3.1.0"

kotlin {
@Suppress("OPT_IN_USAGE")
jvm().mainRun {
// Optionally, set the main class for `runJvm`.
mainClass = "myapp.MainKt"
}
sourceSets {
val commonMain = getByName("commonMain") {
commonMain {
dependencies {
implementation("io.ktor:ktor-client-core:$ktorVersion")
}
}
val jvmMain = getByName("jvmMain") {
jvmMain {
dependencies {
implementation("io.ktor:ktor-client-okhttp:$ktorVersion")
}
Expand Down
4 changes: 2 additions & 2 deletions src/main/kotlin/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,14 +108,14 @@ constructor(private val softwareComponentFactory: SoftwareComponentFactory) : Pl
val shadowRuntimeElements = configurations.shadowRuntimeElements
val shadowComponent = softwareComponentFactory.adhoc(COMPONENT_NAME)
components.add(shadowComponent)
@Suppress("UNCHECKED_CAST")
@Suppress("UNCHECKED_CAST", "UnstableApiUsage")
shadowComponent.addVariantsFromConfiguration(
shadowRuntimeElements as Provider<ConsumableConfiguration>
) { variant ->
variant.mapToMavenScope("runtime")
}
components.named("java", AdhocComponentWithVariants::class.java) { component ->
@Suppress("UNCHECKED_CAST")
@Suppress("UNCHECKED_CAST", "UnstableApiUsage")
component.addVariantsFromConfiguration(
shadowRuntimeElements as Provider<ConsumableConfiguration>
) { variant ->
Expand Down