Skip to content

Fix strokes with inside/outside alignment not being selectable when above other layers#4207

Merged
Keavon merged 1 commit into
masterfrom
fix-nonselectable-aligned-strokes
Jun 8, 2026
Merged

Fix strokes with inside/outside alignment not being selectable when above other layers#4207
Keavon merged 1 commit into
masterfrom
fix-nonselectable-aligned-strokes

Conversation

@Keavon
Copy link
Copy Markdown
Member

@Keavon Keavon commented Jun 6, 2026

Fixes #4206

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the click target calculation in extend_targets_from_vector to double the stroke width for inside/outside-aligned strokes on closed paths. The reviewer suggested optimizing this logic by combining the subpath collection, closed-path check, and closure modification into a single pass over the iterator to avoid multiple iterations over the allocated vector.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread node-graph/libraries/rendering/src/renderer.rs
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@Keavon Keavon force-pushed the fix-nonselectable-aligned-strokes branch from bfdea77 to c7640b6 Compare June 7, 2026 23:57
@Keavon Keavon merged commit 85ee5e4 into master Jun 8, 2026
10 checks passed
@Keavon Keavon deleted the fix-nonselectable-aligned-strokes branch June 8, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stroke alignment selection bug

1 participant