Merge feature branch into main#31
Merged
Merged
Conversation
Previously, filepath.Match errors were silently discarded with matched, _ :=. Malformed glob patterns (e.g. [invalid) would silently fail to match instead of being skipped gracefully. Now errors cause the pattern to be skipped via continue, preventing silent misbehavior.
…f + SARIF - Remove fmt.Printf debug line from internal/graph/graph.go (Build) and internal/hook/hook.go (Execute) — libraries must not write to stdout. Also drop the now-unused time import in graph.go. - Consolidate duplicate validateGitRef: export ValidateGitRef from internal/context (the canonical location) and replace the identical copy in incremental.go with a call to it (aliased as sightcontext to avoid colliding with the standard context package). - Delete the dead FormatSARIF function and its 11 supporting outputSarif* structs from internal/output/output.go — GenerateSARIF in sarif.go is the canonical implementation (covered by sarif_test.go); FormatSARIF had no callers anywhere in the codebase. - Add TestValidateGitRef_ValidRefs and TestValidateGitRef_RejectsInvalid covering valid refs (branches, tags, SHAs, HEAD, tilde-notation) and the rejection paths (empty, dash-start, shell metachars, whitespace). All sight package tests pass; build is clean. Co-Authored-By: Grok <noreply@xai.com>
- Add qualitygraph/ package with quality analysis - Update README and docs
- Add QualityGraph implementation - Support tracking code quality metrics and relationships - Add issue ranking and threshold tracking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated merge of feature branch into main