fix: make PaySchedule create/edit tests more robust#1547
Merged
serikjensen merged 4 commits intomainfrom Apr 15, 2026
Merged
Conversation
Implements a new useHomeAddressForm hook following the established unstable hooks pattern. Supports create and update modes with address fields (street1, street2, city, state, zip), courtesy withholding toggle, and an optional effective date field. - Schema with configurable requiredness via optionalFieldsToRequire - withEffectiveDateField prop to exclude effective date from schema/UI - Prebuilt HomeAddressForm component with SDKFormProvider integration - Registered in SDK dev app for testing - Updated unstable hooks implementation guide with boolean field guidance Made-with: Cursor
Wait for observable DOM changes (list mode reappearing) instead of asserting on the onEvent mock inside waitFor. The mock assertion was racing against the full async mutation chain and intermittently exceeding waitFor's default 1000ms timeout in CI. Made-with: Cursor
serikjensen
requested review from
dmortal,
hukid,
jeffredodd and
krisxcrash
as code owners
dmortal
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onEventmock insidewaitFor(which races against the full async mutation chain and can exceed the default 1000ms timeout), wait for an observable DOM change (the list mode reappearing after successful form submission), then assert ononEventsynchronouslyTest plan
npm run test -- --run src/components/Company/PaySchedule/PaySchedule.test.tsx— all 14 tests passMade with Cursor