feat: add PolicySettings presentation component for time-off policy creation#1551
Open
krisxcrash wants to merge 1 commit intomainfrom
Open
feat: add PolicySettings presentation component for time-off policy creation#1551krisxcrash wants to merge 1 commit intomainfrom
krisxcrash wants to merge 1 commit intomainfrom
Conversation
…reation Implements the PolicySettings screen UI including: - Toggle-controlled number input fields for accrual maximum, balance maximum, carry over limit, and waiting period settings - Payout on dismissal toggle - CSS grid layout with responsive toggle alignment - i18n translations matching Figma design specs - Storybook stories for hours_worked, fixed, and edit mode variants Part of SDK-577. Follow-up PR will add unit tests.
krisxcrash
requested review from
dmortal,
hukid,
jeffredodd and
serikjensen
as code owners
5 tasks
serikjensen
approved these changes
Apr 15, 2026
Comment on lines
+15
to
+17
| .settingField :global(.react-aria-NumberField) { | ||
| max-width: toRem(200); | ||
| } |
Member
There was a problem hiding this comment.
Nit: why do we need this aria numberfield style selector? NumberField should already take up the width of the container
additionally, this style would break for component adapters if we are relying on setting the style on the react aria input since partners may not be using that.
all field components should just be assumed to take up the width of the container and then we should be able to size the container for layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PolicySettingsPresentationcomponent for the time-off policy settings screen (SDK-577)Test plan
Resolves SDK-577 (presentation layer only — wiring/functionality is a follow-up)