chore: relocate Deductions onboarding flow into onboarding/ subfolder#1995
Open
serikjensen wants to merge 1 commit into
Open
chore: relocate Deductions onboarding flow into onboarding/ subfolder#1995serikjensen wants to merge 1 commit into
serikjensen wants to merge 1 commit into
Conversation
Precursor to migrating the Deductions dashboard card into a standalone management block. The top-level `Deductions.tsx` flow (plus its state machine, contextual adapters, and onboarding-only leaf components) now lives under `Deductions/onboarding/`, matching the canonical layout used by Compensation. This frees up `Deductions/management/` for the next PR to land a card-as-block migration without an existing flow in its way. The public surface is preserved: `Deductions/index.ts` re-exports from `./onboarding`, so the `Deductions` named export continues to resolve through `employeeOnboarding.ts` and the deprecated `Employee/index.ts` barrel. No behavior, event, prop, or i18n changes. Co-authored-by: Cursor <cursoragent@cursor.com>
serikjensen
force-pushed
the
sj/chore/deductions-relocate-onboarding-flow
branch
from
2004c4c to
2eab912
Compare
9 tasks
krisxcrash
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Precursor to migrating the Deductions dashboard card into a standalone management block (per
.claude/skills/migrate-dashboard-card-to-block). The skill flags Deductions as needing a precursor PR because the existing top-levelDeductions.tsxis aBaseComponentInterfaceonboarding flow that lives in the same folder where the card-as-block migration needs to land.This PR is bookkeeping only:
Deductions.tsx,stateMachine.ts,deductionsContextualComponents.{tsx,test.tsx}, and the onboarding-only leaf folders (IncludeDeductions/,DeductionsList/,DeductionsForm/) into a newDeductions/onboarding/subfolder, matching the canonical layout used byCompensation/.Deductions/onboarding/index.tsre-exportingDeductionsand rewritesDeductions/index.tstoexport * from './onboarding'.../shared/...→../../shared/...) and the two consumers that referenced the moved files directly (Dashboard/DashboardComponents.tsx,OnboardingFlow/OnboardingFlowComponents.tsx).Backwards compatibility
The public surface is preserved end-to-end.
Deductionscontinues to resolve throughEmployee/exports/employeeOnboarding.tsand the deprecatedEmployee/index.tsbarrel via the newDeductions/index.tsre-export. The shared hook exports (useDeductionForm,useChildSupportGarnishmentForm) reference@/components/Employee/Deductions/shared/...insrc/index.ts—shared/didn't move, so those paths are unchanged.No behavior, event, prop, or i18n changes. Tests, lint, prettier, and
tscall pass.Follow-up
A second PR will land the actual card-to-block migration into the now-clean
Deductions/management/folder, following the standard pattern documented in the skill.Test plan
npm run test -- --run— 2968 passed, 1 expected failnpm run lint:check— 0 errorsnpm run format:check— cleannpm run tsc— cleanMade with Cursor