fix: add additional copy to remove secondary jobs warning#2005
Merged
Conversation
aaronlee777
changed the title
…ssion alerts are present The alert wrapper Flex was rendering an empty container in the DOM even when no alerts applied. Also adds a translated body to the willDeleteSecondaryJobs warning so partners can localize it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
aaronlee777
force-pushed
the
al/fix/update-remove-secondary-jobs-warning
branch
from
a5c1adc to
8ccf1e8
Compare
krisxcrash
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the alert wrapper
FlexinManagementCompensationFormBodyrendered an empty container in the DOM even when no alerts applied. Also moves the hard-coded English body of thewillDeleteSecondaryJobswarning into an i18n key so partners can localize it.Changes
Flexbehind a check that at least one of the four alert conditions is truevalidations.classificationChangeRemovesSecondaryJobstranslation and use it for the alert bodyDemo
Related
Testing
🤖 Generated with Claude Code