chore(SDK-971): fix release tags and delete unused code#2010
Open
mariechatfield wants to merge 1 commit into
Open
chore(SDK-971): fix release tags and delete unused code#2010mariechatfield wants to merge 1 commit into
mariechatfield wants to merge 1 commit into
Conversation
Contributor
Author
|
These are the actual code changes that inspired the skill and agent changes in #2009 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Jira: SDK-971
Cleanup pass on the phase 1 TSDoc backfill (#1996), correcting release tags that were set incorrectly and removing dead code surfaced by running knip.
Release tag corrections (
@public→@internal)The following are internal SDK plumbing that partners never interact with directly — they were incorrectly tagged
@publicin the backfill:LocaleProvider,LocaleProviderProps,LocaleProps,useLocale— consumed byGustoProvider, not partnersObservabilityProvider,ObservabilityProviderProps,ObservabilityContextValue,useObservability— same patternAlso removes
LocalePropsandObservabilityProviderProps/ObservabilityContextValuefrom their index re-exports, and unexportsCtaConfig(was@internalbut still exported) and removesnormalizeToSDKErrorfrom the ObservabilityProvider barrel (wrong module for it).BaseLayoutPropsandBaseBoundariesPropsremoved from the Base barrel — internal component shape types not part of the partner API.Dead code removal
Hooks surfaced as unused by knip:
useDebounce— deleted (no remaining callers)useForkRef— index deleted (implementation file stays; it's used but the barrel re-export was unused)useOverflowDetection— barrel index deleted, default export removed from implementationBreakpointKeytype — removed fromuseContainerBreakpoints(unused export)API report
.reports/embedded-react-sdk.api.mdupdated to reflect the above — the newly-internal symbols now appear with@internaland theae-internal-missing-underscorewarning (expected; we don't rename internal symbols with a leading underscore).Test plan
npm run buildpassesnpm run test -- --runpasses