fix(H5Zdeflate): suppress C4267 warning#6411
Open
hyoklee wants to merge 3 commits into
Open
Conversation
…r compressBound On MSVC ARM64, size_t is 64-bit while zlib's uLong is 32-bit, causing C4267 (conversion from 'size_t' to 'uLong', possible loss of data).
hyoklee
requested review from
derobins,
fortnern,
jhendersonHDF,
lrknox and
qkoziol
as code owners
hyoklee
requested review from
bmribler,
brtnfld,
glennsong09,
mattjala and
vchoi-hdfgroup
as code owners
| size_t z_dst_nbytes = z_dst_buf_size; | ||
| #else | ||
| uLongf z_dst_buf_size = (uLongf)compressBound(nbytes); | ||
| uLongf z_dst_buf_size = (uLongf)compressBound((uLong)nbytes); |
Collaborator
There was a problem hiding this comment.
A check should be added to make sure that casting nbytes to uLong doesn't actually lose data
if ((size_t)(uLong)nbytes != nbytes)
error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On MSVC ARM64,
size_tis 64-bit while zlib'suLongis 32-bit,causing C4267 (conversion from 'size_t' to 'uLong', possible loss of data).