chore(deps): bump typescript to v6#932
Open
SnowboardTechie wants to merge 3 commits into
Open
Conversation
Contributor
|
🚀 Website Preview Deployed! Preview your changes at: https://cg-pr-932.billy-daly.workers.dev This preview will be automatically deleted when the PR is closed. |
Bump the catalog `typescript` to ^6.0.3 and co-bump `typescript-eslint` to ^8.61.1 (its typescript peer range is >=4.8.4 <6.1.0, so it supports TS 6.0.x). Handle TS 6 breaking changes: - Remove the deprecated `baseUrl` from lib/ts-sdk and website tsconfigs (TS 6 errors on it via TS5101). Both used it only as a prefix for `paths`, so the path entries are made explicitly relative instead. - json-schema-faker@0.6.x (test-only dep) ships an `exports` map with only an `import` condition; under TS 6's stricter exports resolution the CommonJS ts-sdk can't resolve its types. Point them at the bundled declarations via a tsconfig `paths` entry. No changeset: typescript/typescript-eslint are build/dev tools and the emitted .d.ts surface of published packages is byte-identical between 5.9.3 and 6.0.3 (verified by diffing declaration output).
1c503e3 to
27eb1fa
Compare
…ipt-6 # Conflicts: # pnpm-lock.yaml
…ipt-6 # Conflicts: # lib/ts-sdk/tsconfig.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typescriptfrom^5.9.3to^6.0.3(latest 6.x).typescript-eslint^8.61.0→^8.61.1. Itstypescriptpeer range is>=4.8.4 <6.1.0, so it supports TS 6.0.x — that compatibility is what gates this bump, and it passes.baseUrl, stricterexportsresolution) so the whole workspace stays green.Changes proposed
pnpm-workspace.yaml:typescript→^6.0.3,typescript-eslint→^8.61.1.lib/ts-sdk/tsconfig.jsonandwebsite/tsconfig.json: removed the deprecatedbaseUrl.lib/ts-sdk/tsconfig.json: added ajson-schema-fakerpathsentry pointing at its bundled declarations.pnpm-lock.yaml: regenerated.Context for reviewers
Breaking changes handled
baseUrldeprecated (TS5101). TS 6 errors onbaseUrland removes it as a module-resolution lookup root. Bothts-sdkandwebsiteused it only as a prefix forpaths, so per the TS 6 migration guidance it's removed and thepathsvalues are made explicitly relative (./src/*etc.) — resolution is unchanged.Stricter
exportsresolution (TS2307).json-schema-faker@0.6.x(a test-only devDependency) ships anexportsmap with only animportcondition — norequire/default.ts-sdkcompiles in CommonJS mode, so under TS 6's stricter resolutiontscenters the conditional exports, finds no matching condition, and no longer falls back to the top-leveltypesfield (TS 5 did).--traceResolutionconfirmedSaw non-matching condition 'import' … Module name 'json-schema-faker' was not resolved. The package's bundled.d.tsis valid and runtime resolution (vitest/esbuild) is unaffected, so apathsentry points types at the bundled declarations. Downgrading to the last 0.5.x (which has a correctexportsmap) was rejected — 0.6.x changedgenerateto async, so it's an API change unrelated to this bump.Verification
pnpm run ci(core → changelog-emitter → cli → sdk → website) passes end-to-end, exit 0. Tests: 7 + 18 + 22 + 7 across the suites; lint, prettier, and CSpell clean.typescript/typescript-eslintare build/dev tools, and the emitted public.d.tsof the published packages is byte-identical between 5.9.3 and 6.0.3 (verified by diffing declaration-only output ofts-sdk— 56 files, zero differences). No consumer-visible surface change.Additional information
templates/express-jsusesmoduleResolution: "node"(the node10 resolver, not the removedclassic) and isn't in the pnpm workspace, so it's unaffected. NooutFileortarget: es5usage anywhere.CI note: undici override (dropped on rebase)
An earlier revision carried a
pnpm-workspace.yamloverride pinningundicito7.28.0to clear a high advisory (GHSA-vmh5-mc38-953g, TLS cert validation bypass) that was failingvalidateonmainand all sibling catalog PRs. That override has been dropped:mainnow resolvesundici@7.28.0transitively on its own, so it's no longer needed. Verified after rebasing onto currentmain—audit-deps.js --level highreports no high-severity advisories, withundiciresolving to7.28.0.