Fixes 2026 05 27

.eslintrc.js

@@ -0,0 +1,27 @@
+module.exports = {
+  env: {
+    browser: true,
+    es2021: true,
+  },
+  extends: "eslint:recommended",
+  parserOptions: {
+    ecmaVersion: "latest",
+    sourceType: "script",
+  },
+  globals: {
+    $: "readonly",
+    dolog: "readonly",
+    EventSource: "readonly",
+    jQuery: "readonly",
+    runtext: "readonly",
+    showusers: "readonly",
+  },
+  overrides: [
+    {
+      files: ["tests/js/*.test.js"],
+      env: {
+        node: true,
+      },
+    },
+  ],
+};

.github/workflows/python-app.yml

@@ -26,14 +26,35 @@ jobs:
             requirements.txt
             requirements-dev.txt
 
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: "20"
+          cache: npm
+          cache-dependency-path: package-lock.json
+
+      - name: Set up PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: "8.3"
+          coverage: none
+
+      - name: Show tool versions
+        run: |
+          python --version
+          node --version
+          npm --version
+          php --version
+          google-chrome --version || chromium --version || chromium-browser --version || true
+
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
           make venv
           make pip-sync-dev
 
-      - name: Run lint and formatting checks
-        run: make lint
-
       - name: Run tests
         run: make test
+
+      - name: Run lint checks
+        run: make lint

.gitignore

@@ -0,0 +1,8 @@
+config.yaml
+.coverage
+.pytest_cache/
+.venv/
+__pycache__/
+node_modules/
+tests/__pycache__/
+tests/plugins/__pycache__/

Makefile

@@ -1,7 +1,24 @@
 PYTHON ?= python3
+NPM ?= npm
+PHP ?= php
+PY_FILES := kassa.py $(shell find plugins tests -type f -name '*.py' | sort)
+PHP_FILES := $(shell find www -type f -name '*.php' | sort)
 
-test:
+.PHONY: test python-test js-test php-test venv pip-compile pip-sync pip-sync-dev lint python-lint js-lint php-lint check-types fix check
+
+test: python-test js-test php-test
+
+python-test: venv
 	@. .venv/bin/activate && ${env} ${PYTHON} -m pytest  -vvv --cov=. --cov-report term-missing
+
+js-test: node_modules/.package-lock.json
+	@${NPM} run test:js
+
+php-test:
+	@${PHP} tests/php/test_php_files.php
+
+check: test lint ## Run tests and linters
+
 venv: .venv/make_venv_complete ## Create virtual environment
 .venv/make_venv_complete:
 	${PYTHON} -m venv .venv
@@ -22,12 +39,23 @@ pip-sync-dev: ## synchronizes the .venv with the state of requirements.txt
 	. .venv/bin/activate && ${env} pip install -U pip-tools
 	. .venv/bin/activate && ${env} ${PYTHON} -m piptools sync requirements.txt requirements-dev.txt
 
-lint: venv  ## Do basic linting
+lint: python-lint js-lint php-lint  ## Do basic linting
+
+python-lint: venv
 	@. .venv/bin/activate && ${env} ${PYTHON} -m pylint --persistent=no kassa.py plugins
-	@. .venv/bin/activate && ${env} ${PYTHON} -m black --check kassa.py plugins tests
+	@. .venv/bin/activate; for file in ${PY_FILES}; do ${env} ${PYTHON} -m black --check --quiet --workers 1 "$$file" || exit $$?; done
+
+node_modules/.package-lock.json: package.json package-lock.json
+	${NPM} ci
+
+js-lint: node_modules/.package-lock.json
+	@${NPM} run lint:js
+
+php-lint:
+	@for file in ${PHP_FILES}; do ${PHP} -l "$$file" || exit $$?; done
 
 check-types: venv ## Check for type issues with mypy
 	@. .venv/bin/activate && ${env} ${PYTHON} -m mypy --check .
 
 fix:
-	@. .venv/bin/activate && ${env} ${PYTHON} -m black kassa.py plugins tests
+	@. .venv/bin/activate; for file in ${PY_FILES}; do ${env} ${PYTHON} -m black --quiet --workers 1 "$$file" || exit $$?; done

config.py

@@ -0,0 +1,71 @@
+import copy
+import os
+
+import yaml
+
+
+CONFIG_PATH = "config.yaml"
+
+DEFAULT_CONFIG = {
+    "mqtt": {
+        "host": "localhost",
+        "port": 1883,
+        "keepalive": 60,
+    },
+    "door": {
+        "mqtt": {
+            "host": "mqtt.space.hack42.nl",
+            "port": 1883,
+            "keepalive": 60,
+            "topic": "hack42/brandhok/deuropen",
+        },
+    },
+    "stickers": {
+        "printer": {
+            "model": "QL-710W",
+            "host": "localhost",
+            "port": 9100,
+        },
+    },
+    "pos": {
+        "serial": {
+            "port": "/dev/ttyUSB0",
+            "baudrate": 19200,
+        },
+    },
+    "logging": {
+        "level": "INFO",
+    },
+}
+
+
+def _merge_config(base, override):
+    merged = copy.deepcopy(base)
+    for key, value in override.items():
+        if isinstance(value, dict) and isinstance(merged.get(key), dict):
+            merged[key] = _merge_config(merged[key], value)
+        else:
+            merged[key] = value
+    return merged
+
+
+def load_config(path=None):
+    path = path or os.environ.get("KASSA_CONFIG", CONFIG_PATH)
+    if not os.path.exists(path):
+        return copy.deepcopy(DEFAULT_CONFIG)
+
+    with open(path, encoding="utf-8") as config_file:
+        loaded = yaml.safe_load(config_file) or {}
+
+    if not isinstance(loaded, dict):
+        return copy.deepcopy(DEFAULT_CONFIG)
+    return _merge_config(DEFAULT_CONFIG, loaded)
+
+
+def config_get(*keys, default=None):
+    value = load_config()
+    for key in keys:
+        if not isinstance(value, dict) or key not in value:
+            return default
+        value = value[key]
+    return value

config.yaml.example

@@ -0,0 +1,30 @@
+# Copy this file to config.yaml and adjust local values.
+# config.yaml is intentionally git-ignored so local secrets/device settings are not overwritten.
+
+mqtt:
+  host: localhost
+  port: 1883
+  keepalive: 60
+
+door:
+  mqtt:
+    host: mqtt.space.hack42.nl
+    port: 1883
+    keepalive: 60
+    topic: hack42/brandhok/deuropen
+
+stickers:
+  printer:
+    model: QL-710W
+    host: BRW008092D4A414.space.hack42.nl
+    port: 9100
+    # Optional override when the brother_ql backend needs a full identifier:
+    # identifier: tcp://BRW008092D4A414.space.hack42.nl:9100
+
+pos:
+  serial:
+    port: /dev/ttyUSB0
+    baudrate: 19200
+
+logging:
+  level: INFO

input_validation.py

@@ -0,0 +1,43 @@
+import re
+
+
+RESERVED_INPUTS = {"abort", "ok"}
+INPUT_TOKEN_RE = re.compile(r"^[A-Za-z0-9]+$")
+
+
+def reserved_inputs(master=None, plugin_help=None):
+    reserved = set(RESERVED_INPUTS)
+    if isinstance(plugin_help, dict):
+        reserved.update(plugin_help.keys())
+    master_help = getattr(master, "help", {})
+    if isinstance(master_help, dict):
+        reserved.update(master_help.keys())
+    return reserved
+
+
+def is_reserved_input(text, master=None, plugin_help=None):
+    return text in reserved_inputs(master=master, plugin_help=plugin_help)
+
+
+def filter_reserved_aliases(aliases, master=None, plugin_help=None):
+    return [
+        alias
+        for alias in aliases
+        if not is_reserved_input(alias, master=master, plugin_help=plugin_help)
+    ]
+
+
+def is_valid_input_token(text, min_length):
+    return (
+        isinstance(text, str)
+        and len(text) >= min_length
+        and INPUT_TOKEN_RE.fullmatch(text) is not None
+    )
+
+
+def is_valid_alias(text):
+    return is_valid_input_token(text, min_length=6)
+
+
+def is_valid_product_name(text):
+    return is_valid_input_token(text, min_length=4)