build: use Docker secrets for GIT_ACCESS_TOKEN#855
Conversation
Dokploy Preview Deployment
|
Norbiros
left a comment
Norbiros
left a comment
There was a problem hiding this comment.
I am not sure if the fix for this issue will be that simple. Remember that we are deploying it in dokploy, and we need to be sure that it is possible.
Signed-off-by: lajczi <lajczi@disroot.org>
| ARG GIT_ACCESS_TOKEN=token | ||
| ARG BRANCH=master | ||
| # Pass --build-arg CACHEBUST=$(date +%s) to invalidate cache when tasks repo updates | ||
| ARG CACHEBUST=0 |
There was a problem hiding this comment.
I stated that it needs to work with dokploy and there is no way to pass random parameter.
There was a problem hiding this comment.
can I just remove CACHEBUST arg? In Dokploy you can use the "Force Rebuild" button which clears docker's build cache achieving the same effect
There was a problem hiding this comment.
otherwise I can't really use secrets because it just won't work with cache
There was a problem hiding this comment.
We don't want to force rebuild of the entire application every time.
|
This issue is really complex and probably requires complete rewrite of pulling & providing tasks for the core web server. If you want you can look into that, but first please, discuss it with me. |
3 participants
Closes #854