Skip to content

Add referral bonus during grading - #235

Draft
renkaichen wants to merge 1 commit into
mainfrom
referral
Draft

Add referral bonus during grading#235
renkaichen wants to merge 1 commit into
mainfrom
referral

Conversation

@renkaichen

Copy link
Copy Markdown
Contributor

Description

Issues

@crystaltine crystaltine left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda works, but it only applies the bonus when the last essay is graded, so if someone is referred after their essays have already been graded, the bonus never gets checked, i think.

I think maybe it would be better to just store a separate referral bonus field and do the sum when we rank grading rather than bumping the raw score?

OR maybe we can just have the referral routes also update the application score and then make sure neither route that touches the application score overwrites it (+= instead)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants