Updated shepherd.go#12
Merged
Merged
Conversation
Made it so it hides all old images instead of just the most recent
There was a problem hiding this comment.
Pull request overview
This PR updates the image “shepherd” workflow so that after a successful upload it renames/hides all previously-matching (non-hidden) images, rather than only the most recently matched one.
Changes:
- Collect all matching existing images into a slice for later processing.
- After upload, iterate over all matched images and call
RenameHideByIDfor each.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| // Find current "latest" image matching either properties or name (non-hidden) | ||
| var current *images.Image | ||
| var allImages []*images.Image |
Comment on lines
113
to
+156
| @@ -147,12 +151,14 @@ func Run(c *gophercloud.ServiceClient, imagesCfg []image.Image) { | |||
| } | |||
| } else { | |||
| zap.S().Infow("Upload complete", "name", imgCfg.Name) | |||
| if current != nil { | |||
| zap.S().Infow("Renaming/hiding previous image", "previous_id", current.ID, "previous_name", current.Name) | |||
| if err := image.RenameHideByID(c, current.ID); err != nil { | |||
| zap.S().Errorw("Failed to rename/hide previous image", "id", current.ID, "error", err) | |||
| } else { | |||
| zap.S().Infow("Previous image renamed/hidden", "id", current.ID) | |||
| if len(allImages) > 0{ | |||
| for _, old := range allImages{ | |||
| zap.S().Infow("Renaming/hiding previous image", "previous_id", old.ID, "previous_name", old.Name) | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made it so it hides all old images instead of just the most recent