feat: DB_SCHEMA schema isolation + ACR CI secrets docs#9
Merged
Conversation
- storage.py: create schema + SET search_path using DB_SCHEMA env var - .env.example: add DB_SCHEMA placeholder with explanation - README.md: add DB_SCHEMA to run/deploy steps, <your_table> placeholder in verify command, and new Enable ACR push from CI section Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
storage.py: creates schema and setssearch_pathviaDB_SCHEMAenv var so each student's tables land in their own schema, notpublic.env.example: addsDB_SCHEMA=dev_<your_github_handle>placeholder with explanationREADME.md: addsDB_SCHEMAto run/deploy steps, uses<your_table>placeholder in the verify command (notweather_readings), adds "Enable ACR push from CI (optional)" section with secret namesTest plan
uv run python -m src.pipelinewithDB_SCHEMA=dev_testcreatesdev_test.weather_readingsDB_SCHEMA, falls back topublic(backwards-compatible)<your_table>placeholder does not confuse students into thinking the table must be namedweather_readings🤖 Generated with Claude Code