ci: drop Node 18 from test matrix — vitest 4/rolldown requires Node 20+#108
Open
dmchaledev wants to merge 1 commit into
Open
ci: drop Node 18 from test matrix — vitest 4/rolldown requires Node 20+#108dmchaledev wants to merge 1 commit into
dmchaledev wants to merge 1 commit into
Conversation
The Node 18 leg has been failing on every run since #66 introduced the matrix: vitest 4's dependency chain (vite -> rolldown) requires Node ^20.19.0 || >=22.12.0 and throws `SyntaxError: The requested module 'node:util' does not provide an export named 'styleText'` before any test executes. This is the current state of main's HEAD commit itself (workflow run 27606677557, conclusion: failure), and every open PR inherits the same failing check. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CwgPkJznwiQLFemYH9BhrQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
main's current HEAD (0ce2274, the commit that added the Node 18/20/22 test matrix in #66) has a failing CI run (workflow run 27606677557, conclusion:failure). The Node 18 job fails before a single test executes:Root cause:
vitest@4.1.7's dependency chain (vite→rolldown) requires Node^20.19.0 || >=22.12.0(confirmed vianpm install --include=dev'sEBADENGINEwarnings on Node 18). This is a test-tooling constraint, not a constraint on the published library itself (src/only usesfetch/AbortController, both fine on Node 18).I spot-checked several of the currently-open PRs (#98, #99, #103, and this repo's own PR history) and every one fails the same Node 18 leg for the same reason — it's not specific to any one PR's changes. This means CI has been red on
mainand on every open PR since 2026-06-16, which lines up with the merge freeze described in #102 ("no PR has merged into main since 2026-06-16").Fix
Drop
'18'from.github/workflows/ci.yml's test matrix, leaving['20', '22'].package.json'senginesfield (>=18.0.0) is left untouched since it describes the published library's runtime requirement, not the test toolchain's.Verified locally
npm install --include=dev— clean (Node 22)npm run typecheck— passesnpm test— 85/85 passnpm run build— passesRelated
Generated by Claude Code