Flakey Weak Hash Test and CI Update#1348
Open
Aidan63 wants to merge 8 commits into
Open
Conversation
added 8 commits
June 15, 2026 21:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another VS/MSVC release, another failing GC test due to new optimisations. The weak hash tests were using a "create a really deep call stack" trick to try and prevent compilers optimising away function calls which would then cause GC objects to be visible on the stack and prevented from being collected.
Other tests were doing similar things and I switched those to have the objects be created on a thread after MSVC could work around that, I've now done the same thing with the weak hash tests to get it passing again.
I've also included a CI fix to make sure for nightly haxe it downloads the test suite for the exact nightly being used as opposed to the latest commit. I would have put this as a separate merge but the CI will fail without it.