Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…lper Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Make all wildcard imports explicit (CenterIndexedArrays, ImageCore, RegisterCore)
- Remove stale non-public Base imports: unsafe_length, index_shape
- Replace Base.ViewIndex with inlined Union{Real,AbstractArray}
- Remove no-op Base.@_propagate_inbounds_meta
- Replace Base.reindex with explicit unsafe_reindex fallback methods
- Add test_explicit_imports to test suite
- Add ExplicitImports to [extras]/[targets] with compat "1"
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fix truncatenoise! array-of-arrays method (used undefined `denoms`) - Fix allocate_mmarrays real-matrix method (wrong MismatchArray type parameter) - Fix default_aperture_width error message (tuple indexed by tuple) - Fix computeoverlap (non-broadcasting max, tuple-minus-vector) - Add Base.length/eltype to ContainerIterator and FirstDimIterator - Add 121 new tests covering all testable utility functions - Coverage: 0% → 87.8% Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds docstrings to all 10 previously undocumented exported symbols (mismatch, set_FFTPROD, DimsLike, WidthLike, assertsamesize, checksize_maxshift, padranges, padsize, shiftrange, tovec) and the module itself. Fixes existing docstrings for correctbias!, mismatch0, nanpad, aperture_grid, allocate_mmarrays, default_aperture_width, each_point, truncatenoise!, and register_translate (corrects <= vs <, misleading thresh description, keyword arg notation, missing return types, and missing overloads). Adds a jldoctest example to aperture_grid. Wires Documenter.jl into the test suite so doctests run with Pkg.test(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
RegisterCore 1.0 renamed indmin_mismatch to argmin_mismatch (breaking). The compat allowed "0.2, 1", so CI resolved RegisterCore 1.0.1 and failed to precompile. Update the import and call site, and tighten the lower bound to "1". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Base.tail is not part of Julia's public API. Replace all uses with size(x)[2:end] (in FirstDimIterator) and a local _tail helper (in unsafe_reindex), both of which rely only on public indexing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Tokenless uploads are no longer accepted by Codecov. Switch to codecov-action@v4 and supply the repository secret. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #18 +/- ##
===========================================
+ Coverage 0.00% 87.44% +87.44%
===========================================
Files 1 1
Lines 240 239 -1
===========================================
+ Hits 0 209 +209
+ Misses 240 30 -210 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
padsize(blocksize, maxshift)andpadsize!Test plan
minand1Julia versions🤖 Generated with Claude Code