Conversation
- Fix `sz[i]>>1+1` → `(sz[i]>>1)+1` in block_center (operator
precedence bug; was computing sz>>2 instead of (sz>>1)+1)
- Add Counter(max::AbstractVector{<:Integer}) constructor to accept
any integer vector, not just Vector{Int}
- Add Base.length(c::Counter) so Counter composes with collect,
comprehensions, and IteratorSize-aware code
- Annotate Base.iterate(c, state::Vector{Int}) for clarity
- Reorder quadratic(shift, Q, denom::Matrix) → quadratic(denom, shift, Q)
to put data first, following Julia convention; widen denom to AbstractMatrix
- Infer output eltype in quadratic from float(eltype(Q)) instead of
hardcoding Float64
- Add tests for block_center and the AbstractVector Counter constructor
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Breaking change: quadratic(denom, shift, Q) argument order reversed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Cover RegisterUtilities (module), Counter, quadratic, block_center, and tighten with full Julia-style docstrings including argument descriptions and examples. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.