feat(entities): apply note-surface DNA and arm Live capture - #601
Merged
Conversation
… with score receipts Scored the entity notebook against the note-surface reference corpus (node-platform atlas), fixed only the two lowest-scoring criteria, and re-scored. Receipts validate under reference-corpus-gate (exit 0) and live in docs/design/note-surface/ so provenance travels with the app. rule-stream-not-chrome 1 -> 3: header card, three bordered provenance panels, evidence chips, backlink/related cards and linked-entity pills all became divider-separated rows or inline links; routing/plan panels now default closed so the stream leads the page. rule-single-accent-inline 1 -> 3: accent demoted from chrome (routing pill, mode badge, tool names, parallel badges, decorative icons, model and cost chips); accent now reserved for meaning carriers (citations, evidence links, entity-link tokens, live status, capture affordance); removed both hardcoded #d97757 literals from the editor mode toggle. rule-capture-always-armed 2 -> 2: untouched by this diff, score held honestly; the always-armed capture keystroke is named as the next fix. Suite before and after: 23 files / 247 tests passing (vitest, apps/web/src/features/entities/components). tsc and the agent-native UI linter clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR size advisoryThis PR adds 636 lines of substantive change. CONTRIBUTING.md defines a soft limit of ~400 LOC. If the PR is genuinely cohesive (e.g. an architecture map, a generated migration, a deletion of a dead module), no action is needed. Otherwise consider:
This is advisory — it does not block the merge. |
✅ Dogfood Visual QA Gate: PASSED
ArtifactsDownload the Generated by Dogfood QA Gate |
Preserve workspace write authority beneath read mode so Cmd/Ctrl+E can enter the Live editor without broadening shared or block-level access. Focus the first editable block, deduplicate empty creation, and keep active-input and read-only paths fail-closed. Add Mobbin, Mew, and Roam reference facts, validated design rules, before/after scenario evidence, and per-surface changelog lanes. Co-Authored-By: Codex <noreply@openai.com>
HomenShum
changed the title
|
Demo: walkthrough of the surfaces this PR changed is available as a workflow artifact ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the reference-grounded note surface and closes the Live notebook capture gap without broadening workspace authority.
Root cause
EntityNotebookSurfaceconverted write authority intocanEditNotebook && !isReadModebefore mounting the Live notebook.EntityNotebookLiveapplied the same read-mode mask again. Once the page entered read mode, the Live component could no longer distinguish an owner who may return to editing from a genuinely shared or read-only viewer. Cmd/Ctrl+E therefore changed the route mode but could not reliably focus or create an editable block.What changed
EntityNotebookLiveremains responsible for the temporary read-mode mask.capture-always-armedfrom 2 to 3 only after the desktop behavior was scenario-proven. Mobile capture and signed-in production timing remain explicitly unclaimed.Reference-backed score delta
stream-not-chromesingle-accent-inlinecapture-always-armedNodeKit corpus gate: 10/10 records validated, 21 atomic facts, 53 citations, 6 criterion scores.
Verification
npx vitest run apps/web/src/features/entities/components/notebook/EntityNotebookLive.empty-state.test.tsx apps/web/src/features/entities/components/EntityNotebookSurface.test.tsx— 15/15 passed.npx tsc --noEmit --pretty false— passed.npm run build— passed.reference-corpus-gate.mjs docs/design/note-surface— passed.evidence/note-surface-live-capture/.20f1653e558f4e5a64df30169ba82f9859cfc543.Visual and deployment boundary
The exact-head preview and CI are still running. The Chrome pass reached the preview but the entity workspace requires a signed-in NodeBench account. No account was selected and no visual/live claim is made yet. Final browser capture, demo verification, merge, production deployment age, raw-HTML signal, and production interaction remain release gates.
Non-goals