Allow a submission to have multiple projects associated#4897
Open
frjo wants to merge 6 commits into
Open
Conversation
wes-otf
approved these changes
Jul 2, 2026
wes-otf
left a comment
Contributor
There was a problem hiding this comment.
This is such an elegant solution! Did a pretty intensive test and it seems like everything is working as expected. The fact that I even changed MULTIPLE_PROJECTS_ENABLED=1 → MULTIPLE_PROJECTS_ENABLED=0 and nothing broke but preserved the multiple projects while not allowing multiples to be created moving forward was also really impressive. All the x.submission.id → x.pk changes look like they must've been painful hahaha.
Overall great work!
Comment on lines
+2
to
+10
| {% comment %} | ||
| Renders the "Project(s)" tab inside a submission/project tablist. | ||
|
|
||
| Params: | ||
| submission – the ApplicationSubmission | ||
| user – the current user (for access filtering) | ||
| current_project – the project being viewed, if any (for active item highlight) | ||
| active – whether this tab is the active one | ||
| {% endcomment %} |
Contributor
There was a problem hiding this comment.
I like this format of kinda docstringing a template! super useful when trying to track down what the variables used are & where they come from
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4869
Test Steps