Refactor JUnit 5 for BaseTestAESCCMInteropBC and BaseTestAESGCMUpdateInteropBC tests - #1659
Open
Mohit-Rajbhar100698 wants to merge 1 commit into
Open
Conversation
jasonkatonica
requested review from
JinhangZhang,
KostasTsiounis,
jasonkatonica and
johnpeck-us-ibm
July 23, 2026 12:29
jasonkatonica
requested changes
Jul 23, 2026
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| public class BaseTestAESGCMUpdateInteropBC extends BaseTestJunit5Interop { | ||
| @Tag(Tags.OPENJCEPLUS_NAME) |
Member
There was a problem hiding this comment.
This test was previously being run for FIPS provider. Any reason it is not tagged with the fips provider?
I did confirm in the logs that TestAESGCMUpdateInteropBC is only running for OpenJCEPlus not OpenJCEPlusFIPS, for example:
TestAll TestAESGCMUpdateInteropBC [1] provider=OpenJCEPlus, interopProvider=BC
Collaborator
Author
There was a problem hiding this comment.
And this test previously was running only for OpenJCEplus
and I tried running with OpenJCEPlusFIPS tags and it ran successfully , should I add OpenJCEPlusFIPS tag also for this test ?
Member
There was a problem hiding this comment.
Yes please add this for FIPS as the test is applicable since AES/GCM is supported by fips provider.
Collaborator
Author
There was a problem hiding this comment.
Added tag for FIPS
Mohit-Rajbhar100698
force-pushed
the
refactor/aes-interop-junit5
branch
from
July 27, 2026 09:53
1ed7846 to
7a8b96e
Compare
Mohit-Rajbhar100698
force-pushed
the
refactor/aes-interop-junit5
branch
2 times, most recently
from
July 28, 2026 15:21
a2fbddf to
e28f545
Compare
johnpeck-us-ibm
approved these changes
Jul 28, 2026
Mohit-Rajbhar100698
force-pushed
the
refactor/aes-interop-junit5
branch
2 times, most recently
from
August 18, 2026 07:00
514a3c7 to
eafda27
Compare
…InteropBC tests This change converts these tests to use JUnit 5 parameterized tests. - Convert BaseTestAESCCMInteropBC to a JUnit 5 parameterized test - Convert BaseTestAESGCMUpdateInteropBC to a JUnit 5 parameterized test - Remove the provider-specific wrapper test classes - Update TestAll.java to remove references to the deleted test classes - Add a new argument source method in TestArguments.java for the BC provider interoperability tests. Signed-off-by: Mohit Rajbhar <mohit.rajbhar@ibm.com>
Mohit-Rajbhar100698
force-pushed
the
refactor/aes-interop-junit5
branch
from
August 18, 2026 07:40
eafda27 to
56117dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change converts these tests to use JUnit 5 parameterized tests.
Signed-off-by: Mohit Rajbhar mohit.rajbhar@ibm.com