Introduce SystemAccessUtils to all Security Manager permission checks - #1668
Open
taoliult wants to merge 1 commit into
Open
Introduce SystemAccessUtils to all Security Manager permission checks#1668taoliult wants to merge 1 commit into
taoliult wants to merge 1 commit into
Conversation
taoliult
requested review from
JinhangZhang,
KostasTsiounis,
jasonkatonica and
johnpeck-us-ibm
July 23, 2026 22:41
taoliult
force-pushed
the
java21_SecurityManager
branch
from
July 27, 2026 14:24
40bc863 to
12c3b33
Compare
johnpeck-us-ibm
requested changes
Jul 27, 2026
KostasTsiounis
requested changes
Jul 27, 2026
taoliult
force-pushed
the
java21_SecurityManager
branch
from
July 27, 2026 18:57
a435aee to
81b622d
Compare
| @@ -143,7 +143,7 @@ public List<ServiceDefinition> readServices() throws IOException { | |||
| throw new IOException("File not found: " + filePath); | |||
Collaborator
There was a problem hiding this comment.
Should we add a privileged check on this Files.exists() function?
taoliult
force-pushed
the
java21_SecurityManager
branch
from
July 28, 2026 00:36
4501cde to
13f8e2c
Compare
johnpeck-us-ibm
approved these changes
Jul 28, 2026
jasonkatonica
requested changes
Jul 28, 2026
taoliult
force-pushed
the
java21_SecurityManager
branch
from
July 28, 2026 21:22
10601e3 to
a7e07b9
Compare
taoliult
force-pushed
the
java21_SecurityManager
branch
from
July 29, 2026 14:06
b0a56a3 to
9323557
Compare
taoliult
force-pushed
the
java21_SecurityManager
branch
6 times, most recently
from
August 10, 2026 17:03
1e50e81 to
d725f65
Compare
Centralize all security manager permission checks in SystemAccessUtils wrapper methods instead of AccessController.doPrivileged() calls throughout the codebase. SystemAccessUtils now wraps all permission-requiring operations: - System property access (getSystemProperty) - File system access (fileExists, newFileReader, getFileCanonicalPath) - Library loading (loadLibrary) - Class loading (forName) This centralizes permission checks in one utility class, making the codebase cleaner and easier to maintain across JDK versions (SecurityManager in JDK 21 and earlier, removed AccessController.doPrivileged() in JDK 25+). Signed-off-by: Tao Liu <tao.liu@ibm.com>
taoliult
force-pushed
the
java21_SecurityManager
branch
from
August 11, 2026 13:42
ed67237 to
5dbb1da
Compare
jasonkatonica
self-requested a review
August 11, 2026 18:20
taoliult
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralize all security manager permission checks in SystemAccessUtils wrapper methods instead of AccessController.doPrivileged() calls throughout the codebase.
SystemAccessUtils now wraps all permission-requiring operations:
This centralizes permission checks in one utility class, making the codebase cleaner and easier to maintain across JDK versions (SecurityManager in JDK 21 and earlier, removed AccessController.doPrivileged() in JDK 25+).
This is a back port PR from PR: #1700