Consolidate common test logic for SHA and MD5 tests - #1692
Open
Mohit-Rajbhar100698 wants to merge 1 commit into
Open
Consolidate common test logic for SHA and MD5 tests#1692Mohit-Rajbhar100698 wants to merge 1 commit into
Mohit-Rajbhar100698 wants to merge 1 commit into
Conversation
This change consolidates the common test logic into a shared base test class. Test classes extend the base class and provide the required test data while reusing the common test methods. This refactoring reduces duplicate test code. Signed-off-by: Mohit Rajbhar <mohit.rajbhar@ibm.com>
Mohit-Rajbhar100698
force-pushed
the
consolidate-sha-md5-tests
branch
from
August 7, 2026 19:52
ac3bb82 to
5c396aa
Compare
Mohit-Rajbhar100698
requested review from
KostasTsiounis,
jasonkatonica and
johnpeck-us-ibm
August 10, 2026 08:47
Member
|
Hi @Mohit-Rajbhar100698 Can you please also add known answer tests for the other tests besides MD5 that are being consolidated here? This will ensure we are following KAT that are published typically in the RFCs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change consolidates the common test logic into a shared base
test class. Test classes extend the base class and provide the
required test data while reusing the common test methods.
This refactoring reduces duplicate test code.
Signed-off-by: Mohit Rajbhar mohit.rajbhar@ibm.com