engineGetKeySpec rejects keys from external providers - #1699
Merged
Conversation
johnpeck-us-ibm
marked this pull request as draft
August 11, 2026 15:58
johnpeck-us-ibm
added a commit
to johnpeck-us-ibm/OpenJCEPlus
that referenced
this pull request
Aug 12, 2026
Added code to PQCKeyFactory to allow for ML-KEM and ML-DSA generic Alg names for key translation. Signed-off-by: johnpeck-us-ibm <johnpeck@us.ibm.com>
johnpeck-us-ibm
added a commit
to johnpeck-us-ibm/OpenJCEPlus
that referenced
this pull request
Aug 12, 2026
Added code to PQCKeyFactory to allow for ML-KEM and ML-DSA generic Alg names for key translation. Signed-off-by: johnpeck-us-ibm <johnpeck@us.ibm.com>
johnpeck-us-ibm
force-pushed
the
PQCKeyTranslate
branch
from
August 12, 2026 17:43
0d61a4e to
0d89671
Compare
johnpeck-us-ibm
requested review from
JinhangZhang,
KostasTsiounis,
jasonkatonica,
taoliult and
thu-ibm
August 12, 2026 17:44
johnpeck-us-ibm
marked this pull request as ready for review
August 12, 2026 17:45
thu-ibm
reviewed
Aug 12, 2026
jasonkatonica
requested changes
Aug 13, 2026
johnpeck-us-ibm
added a commit
to johnpeck-us-ibm/OpenJCEPlus
that referenced
this pull request
Aug 17, 2026
Added code to PQCKeyFactory to allow for ML-KEM and ML-DSA generic Alg names for key translation. Signed-off-by: johnpeck-us-ibm <johnpeck@us.ibm.com>
johnpeck-us-ibm
force-pushed
the
PQCKeyTranslate
branch
from
August 17, 2026 17:11
d4cf636 to
bdd0dba
Compare
KostasTsiounis
requested changes
Aug 18, 2026
KostasTsiounis
left a comment
KostasTsiounis
left a comment
Member
There was a problem hiding this comment.
I'm not sure why we've added assumeFalse("OpenJCEPlusFIPS".equals(getProviderName()));, given that the test is not extended in the bucket of tests for OpenJCEPlusFIPS. Should they be removed or is there another reason?
taoliult
approved these changes
Aug 18, 2026
johnpeck-us-ibm
added a commit
to johnpeck-us-ibm/OpenJCEPlus
that referenced
this pull request
Aug 18, 2026
Added code to PQCKeyFactory to allow for ML-KEM and ML-DSA generic Alg names for key translation. Signed-off-by: johnpeck-us-ibm <johnpeck@us.ibm.com>
johnpeck-us-ibm
force-pushed
the
PQCKeyTranslate
branch
from
August 18, 2026 20:04
3bf9382 to
cbcf9a7
Compare
Member
Can you also remove the |
johnpeck-us-ibm
added a commit
to johnpeck-us-ibm/OpenJCEPlus
that referenced
this pull request
Aug 19, 2026
Added code to PQCKeyFactory to allow for ML-KEM and ML-DSA generic Alg names for key translation. Signed-off-by: johnpeck-us-ibm <johnpeck@us.ibm.com>
johnpeck-us-ibm
force-pushed
the
PQCKeyTranslate
branch
from
August 19, 2026 13:10
035e3b5 to
4cd2f52
Compare
Member
Author
Done |
johnpeck-us-ibm
added a commit
to johnpeck-us-ibm/OpenJCEPlus
that referenced
this pull request
Aug 19, 2026
Added code to PQCKeyFactory to allow for ML-KEM and ML-DSA generic Alg names for key translation. Signed-off-by: johnpeck-us-ibm <johnpeck@us.ibm.com>
johnpeck-us-ibm
force-pushed
the
PQCKeyTranslate
branch
from
August 19, 2026 13:49
5b06dc3 to
0ae8689
Compare
KostasTsiounis
requested changes
Aug 19, 2026
Added code to PQCKeyFactory to allow for ML-KEM and ML-DSA generic Alg names for key translation. Signed-off-by: johnpeck-us-ibm <johnpeck@us.ibm.com>
johnpeck-us-ibm
force-pushed
the
PQCKeyTranslate
branch
from
August 19, 2026 19:38
9a88523 to
88d5600
Compare
thu-ibm
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added code to PQCKeyFactory to allow for ML-KEM and ML-DSA generic Alg names for key translation.
Signed-off-by: johnpeck-us-ibm johnpeck@us.ibm.com