Convert the PBE tests to JUnit 5 parameterized tests. - #1701
Open
Mohit-Rajbhar100698 wants to merge 1 commit into
Open
Convert the PBE tests to JUnit 5 parameterized tests.#1701Mohit-Rajbhar100698 wants to merge 1 commit into
Mohit-Rajbhar100698 wants to merge 1 commit into
Conversation
Mohit-Rajbhar100698
force-pushed
the
refactor/pbe-junit5-parameterization
branch
2 times, most recently
from
August 14, 2026 15:43
b1fc47e to
1eec004
Compare
This update convert the existing PBE test classes into Junit5 parameterized test classes. Changes:- - Convert BaseTestPBECipher.java to the parameterized test class TestPBECipher.java. - Convert BaseTestPBECipherInterop.java to the parameterized test class TestPBECipherInterop.java. - Convert BaseTestPBEKeyFactory.java to the parameterized test class TestPBEKeyFactory.java. - Convert BaseTestPBEKeyFactoryInterop.java to the parameterized test class TestPBEKeyFactoryInterop.java. - Convert BaseTestPBEParameters.java to the parameterized test class TestPBEParameters.java. - Remove references to the deleted test classes from src/test/java/ibm/jceplus/junit/openjceplus/TestAll.java. Signed-off-by: Mohit Rajbhar <mohit.rajbhar@ibm.com>
Mohit-Rajbhar100698
force-pushed
the
refactor/pbe-junit5-parameterization
branch
from
August 14, 2026 15:45
1eec004 to
c073872
Compare
Mohit-Rajbhar100698
requested review from
KostasTsiounis,
jasonkatonica and
johnpeck-us-ibm
August 17, 2026 06:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update convert the existing PBE test classes into Junit5 parameterized
test classes.
Changes:-
Signed-off-by: Mohit Rajbhar mohit.rajbhar@ibm.com