Add configAlgName for NativeCryptoSelector backend lookup in PBES2Core - #1720
Open
taoliult wants to merge 1 commit into
Open
Add configAlgName for NativeCryptoSelector backend lookup in PBES2Core#1720taoliult wants to merge 1 commit into
taoliult wants to merge 1 commit into
Conversation
Follow the same pattern as PBES1Core, pass the registered Cipher service name (e.g. "PBEWithHmacSHA1AndAES_128") to PBKDF2Core and AESCipher so that NativeCryptoSelector resolves the backend against the same service as the caller. Signed-off-by: Tao Liu <tao.liu@ibm.com>
taoliult
force-pushed
the
main_PBES2Core
branch
from
August 19, 2026 13:38
b6dc09c to
1398934
Compare
taoliult
requested review from
JinhangZhang,
KostasTsiounis,
dev-koan,
jasonkatonica and
johnpeck-us-ibm
and removed request for
dev-koan
August 19, 2026 19:06
KostasTsiounis
requested changes
Aug 20, 2026
|
|
||
| if (cipherAlgo.equalsIgnoreCase("AES")) { | ||
| cipher = new AESCipher(provider); | ||
| cipher = new AESCipher(provider, configAlgName); |
Member
There was a problem hiding this comment.
The configAlgName seems to be the same as pbeAlgo. I don't think we need another parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow the same pattern as
PBES1Core, pass the registeredCipherservice name (e.g. "PBEWithHmacSHA1AndAES_128") toPBKDF2CoreandAESCipherso thatNativeCryptoSelectorresolves the backend against the same service as the caller.